PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Tattoos on copied trees are linked

Open
#6,855 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
How is Path of Building expected to behave?

Changes to nodes (tattoos) on different versions of the tree should not have effect on other trees.

How does Path of Building behave?

Changes made to tattoos in duplicated tree (Manage trees -> Copy) will effect the original tree. I am using the Graphics Engine Beta, don't know if it's related to that.

How to reproduce the issue
  1. Open a build, allocate some nodes, add tattoos to them. (assuming this tree is "Default")
  2. Duplicate the tree (Manage trees -> Copy). Let's call it "B". Swap to B.
  3. Reset some nodes, add tattoos to others.
  4. Save the build and reload it.
  5. Changes done to tattoos in B are reflected in Default. After the reload the nodes are not linked anymore.
Character build code
eNrtG9ty4rjyefYrXK7at0wI1yRbsFsk5EJVMmGBmTn7NCVsAdrIEivJSZivPy3JBkOAyNj7dM48ZEDuu7pbrXbT_uMtot4LFpJw1vGrp2e-h1nAQ8JmHf_r-Pbzhf_H77-0B0jNn6ZXMaH6ye-_fGqbz15AkZRfUIQ7_hCxGRa-p5CYYfUtJVn_ASRfCH595CFA9R8HT8Ox7yEZYBZer9F7GIV4iX1vgZiaY84eCePijocd_wtnsB7MkUCBwuIBv2DajRW3FKeISng8QSwkKgWmGqbjXwLvCBE24sEzVneCxwtQMsMD_Z3lAXp9ag8oWmIxUkh5Ev50_C6YB81wD0XwF3RBNMbaVI3zS79yEOUqFlLlwRstMA4zoLV9gAOBb6ZTHCjygq8FUddzxII1k7N9eHlhH2OqyIISvbErqZr7MO7fEa839sGOuUK0Nxhl6J6fNy4Og3P1sdjfiZpfUbCjO3GN0p8xonA-nAEnkrP8SmQx9ps_phRizQl2iCUWL0iRTWn20-bRhLA8JnpEDF1z6WB_DTnAAsJb5UIY4YBDRsjLIyfmA5lid8hceiQIeaU5To-bkStcbsLHCTSEJOcGOeIxdYRUmbSzN5P08NsKqrk3Y_aZcqL1wnUUfSybieWb-8GaaLVWO622IIbOWxeN872Ze76UJED0Eb2RKI4gZY7RM2YZMvXL_e4ymysGSWEf8nl1r_63ROAj0K45DY9BmyMuj8DTAeFkCjgpg980dJ8FbnH2lQmTJbMH7EFbT_EQ_F-f5BOKnXHWbJI4WmOenR1mNsMs4bh0U-kB42B-B_XNECnsljXXkXJRPWhbDexkWw24w7YH6G9i5DCTRtxtpurZ_lpJY-W01A3DYrYczQmmYT7oVLJrtHDIb9rQWWwng2-yy-U0WdScJvmOROh2CuSV6QXJbMb9IOYTcDfXxFAHAkKIXWvegeB_66qa5kPriojHwnHDLbCTAulhYe8QQxzGgdvpdEXhxuMqPUhFaS6MrlIoeO7xcIZzMcmPMYoXC8gUestd8fRJBwUxyVQYn1sO0E_gr05hq89EdwZraGcGq3PencsWirsu-qDOocwa3JnF6qL6CBkhglRvbrlweV9n772bA3cgpwuNAXS8WA34K0g-120KmQ8aCpp1mtorisDs59KZ_ga4E4MbFsZCh4Izj22MXWzGJIJsKWUPKeRJ0y-5JVRh0YO91riavhcm9fE3JAhiqmq6KVuLNbMoMRLB_AGQO3722y2idALJA1Y143bFNJL0p7HA2EPGU3Se1FSMZPpLtl_UDzt-zfcYD7Hs-I1G46R-eVGrnrTOLhu1k2brotk6aVXrZ62T5lmjeXnSrF2eNXxPAflMV6oGJIIMuQhJUHZpnRXoGt6f2l-HD-bDp7lSC_lbpfL6-nq6QGrOp_gNjonTgEeVBZABqT_LZ0LpZ82o0oV_V7P-9dWfdxdRox734svWz39msNrpGMKVlHLbNqdkxX7TYSUIqGbZrr57IYg9Rkpx7vGpp-bY6wo-52wWEw8OZ0E4HEAk0Np1harUevrvSEvUh0WZCikrASSk0Bwopws28xOTW8X7ejlL4GvfLMlKn92hCPQCT5BKIDqGvaaVgSWqt87KJisrqQBighOAqzvLS2-aNrjdE6vip24YSq_uKe41PZ0tPXvcWf0rqQE-tscQ0J45mCWYY0dboCCAyAiW_4olrDyHzGBcNjVD81ePsEBgJHHo3VE-QdTrJvKBbgqS-y6TrL8al2lXdLzkChyzGWnImPCxgWOl-yhwFFEUDHX1b4fQ0z9Pl63zWaPUEPrfdJn_ZxW3EGpXtAj6g9FYenLOX3VFyoW6w9F4udCB1H140GfgFMVUrz7YVw-Mi2jV5fENZpeqP2NEiVoCmFy9uVijJk8hrOColZaJvFpCVXOrb2xbfdsNgI6vRIxTsxtxR1itz9BkwSNhWm617TZqjdvXnE3JLC0eAjwHe2HhMfNmBjMcLfXLgPRNBoujCRaQCzIFxy6c5G1GCn5-9gH86iaYYlzULy4Oo2xekNaY1dplYy-mJDNCn6amsoMqyZRQK8TD_JKLGKfUvO7KKncYMb0hrvic11of6JZ9V5OiNZOtW21Yu6_ABZJt15-TXfdiiW379jtGC87MsnU4wzMBPQCWuEqSYCkH3wGcwQSSrq7orKCQcyD4ve5kKSXkHpuHvbpvYHVIJmbZT8Hy9are6BUttgnVchC6wlTl51vbybdZlgKNsgi18liCh0vPOlwpihXQ6RYKhefc21hEecsxj57dKKb4KNcpYJghHM1eNdemciWLcDzgFfWC-9MsK-7yCLI79TTLsUijhDipl2WVRgm-2SpBoWZRdy3s77XjdresJNzMnYeqJWxdrRyXrhYM8lpZVqyXo0-rcK5oFHXHPJrcYxphVUpoF62UdotSze3cjYIedXSCPNYTyzJ2taxQqBbetTIKupJqy6JVXnFjtApTqJWQr8vYkmOSbUHzN3Ib7whblRWB-ZN_3lxfwiZW894HaoWPtFYJ_lsvgUbhSq94KBe_SxTfjsJmyF9xvle7XUmaPaZzZPpFpnEU6Tamh9_0fwMkdN_Rdn5Mi-ka0cB2Q_tsEau0daZbhj9sN-p90ywLGREZ_JjE06me0vY9qYQZKb-5vb25Hve_3SQoI2wmGkyzKWlSUlgChHgi7bOO_43gV_OwhxUiFGIz4JSihcRhVuZNavfrhmWWlqGTeeZA6TsSgSA6hWQJ3bxhoRvs66cOpMwE8ztxrCx6Xka_hXUilPRWs6TsUMY1kspO9DhQ0S3GTSJ6xU0V8B9Et4ybrrkooBXXHXT9nlruMIrS3fUFDsiUBAmM266nPdMN2yQvRZxomOnxTfxkyQHZzoRvYqdrLlY1Y-hbVk3WXPwLB2i5iZ0sOSCvJsI2CayWObvX7uJA6YbiLqF61mNrZ79wZpwd4mYN4EDwEbJJ8l5xk-CTmmOxeuJACaJEkEmstsM5u-5iKzOoumEms-KiixnDzKLaFRe7bswlbmSjjSduSW2LhF1xQE3HhbLIds1xC5KmzIb5kzUXI6SviTb0TxddgsSk2-4LJ-H7TPHuYVGCZrCuBLn06FxxMttDdU4UTWWxFS_p2pHoXxXRrzp3UDHvMd2I6JArRkFHnjuF4btqYrhdQ-zB1Pmrh6dYv-fekcDWjxxz4W5aIxWzHpxzynVjPxBrdxQcp2KS7ndquoeideTktwPvYzR54BwR-wjBWXTvWvTspbQacrzHiOpfhnFajOC7H08U0hOuFoiFPT2ZXVBRPdgdL4BYKtnTrrJ1taPtSnqRaJs7hocWC8xWjL2RnosIX7STjcFm2akICdU1Sk4HSi21L1zZGQ1NOf1iJgf1HcHOZ0Ct2COwHcI4WjoY8ZPzdDSjab_91fE_15vV01bLfv-P_l4_P2220nnFkRJ2TLFd2f4B7H8BlcbkAQ==
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Path of Building using the provided build code: add tattoos, use Manage trees -> Copy, change tattoos in the copied tree, save, and reload. Trace the tree-copy and save/load entry points involved in tattoo state; done means copied trees have independent tattoo changes both before and after reloading.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.