PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Trade search weapon type selection, currently only uses the equipped weapon type.

Open
#6,832 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

Currently, if I have a dagger equipped on my character (for example a spell damage dagger) the POB trade search will only try and find daggers. This may potentially miss mods on other weapon types that would greatly benefit your character.

I believe that the trade search should provide the option for a 'desired' weapon types, because if there is a wand/sceptre available that is more damage than my dagger, I would take it.

Describe the solution you'd like

The option to generate a trade search for a different weapon type compared to the currently equipped weapon. Simple dropdown that is pre-populated with the current equipped weapon type with the chance to change it.

Describe alternatives you've considered

I have changed the weapon type drop down after opening the trade URL, but this isn't possible inside the client when using poe session id, so you can't easily import/compare dps of items etc. Also i'm not sure all the possible mods are put into the weighted sum, because maybe some mods on a sceptre aren't on a dagger etc?

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the client trade-search flow and the handling of the currently equipped weapon type. Identify where the trade URL and weighted search are generated, then verify that a selectable desired weapon type is carried through search and item import or comparison. Done means the default remains the equipped type while users can choose another supported weapon type inside the client.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
api, desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.