PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Ceinture of Benevolence to work in party tab

Open
#6,826 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

I'd like to be able to see the effect of Ceinture of Benevolence via the party tab

Describe the solution you'd like

Support for Ceinture of Benevolence via party tab

Describe alternatives you've considered

Copying our each mod an inserting them via custom mods

Additional context

I saw it was mentioned here https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/6757 that supporting this would be ideal, so just thought i'd put in a ticket to track the work

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review pull request #6757 first, then trace the party tab implementation and how Ceinture of Benevolence modifiers are represented. The work is done when the item's effect appears correctly through the party tab without requiring manual custom mods.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.