PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Add support for Torchoak reflected damage
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
I'd like to first note that there is one issue on this subject, but it's pretty incomprehensibly written and thus I'd like to open a new request.
In recent past, Torchoak has been massively buffed to reflect 100% of totem life instead of just 25%. It actually made the boots a viable endgame setup that spawned my build this league, but I am still forced to do calculations manually, with more or less flawed -resistance calcs to guesstimate my damage numbers.
Could we please add calculations to the reflected damage to PoB?
Describe the solution you'd like
There are a few things to consider here. To use an example from my build:
Self-ignite with Eye of Innocence that causes totems to take hit damage each time they ignite, causing reflected damage to be dealt in the AoE. This means that calculations should include stuff like:
- ignite chance
- for projectile skills: amount of projectiles (e.g. with galvanic arrow that fires 10 projectiles with barrage support, there are 20 damage reflect instances in a single totem attack due to the arrow and cone being able to shotgun), attack speed, amount of ballista totems
- enemy monster resistance modifiers such as curses, exposure/EE
- increased damage/fire damage taken modifiers such as covered in ash
- and, naturally, totem life, which is already calculated by pob in accordance to support levels
Describe alternatives you've considered
No response
Additional context
Adding my current PoB for context:
https://poe.ninja/builds/ancestor/character/Ydoum/KEKtain
https://pastebin.com/F5gvExVB
Example calculation based on my pob numbers:
Totem count: 9
Totem life: 21839
Projectile count: 14
Damage instances per projectile: 2
Peak attack speed: 3.72
Resistance modifiers: -17 + (-15) + (-25) = -57%
Increased fire damage taken: 20%
Guesstimated damage: 24mil dps without taking resistance modifiers into the account
(9*21839*14*2*3.72*1.2)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source files or tests are named. Start by locating PoB's existing totem-life and damage-calculation entry points, then determine how reflected damage should incorporate ignite chance, projectile and attack counts, resistances, damage-taken modifiers, and totem count; done means these values produce a reflected-damage calculation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100