PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Incorrect formula for bleed stacking calculations with repeating effects
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?
Currently, when supported by gems like Multistrike or Ruthless, a bleeding attack calculates the average damage approximately as follows:
$M_a * \frac{ A + B * N}{N + 1}$
Where the base damage range is between A and B, with N potential stacks of bleed, and an average multiplier of $M_a$.
What is the value from the calculation in Path of Building?
Because the the damage dealt is always the maximum of the stacks, and we know which hits have the highest multipliers, a more accurate calculation would be better approximated as:
$M_x * \frac{ A + B * \frac{N}{R}}{\frac{N}{R} + 1}$
Where R is the repeat factor, and $M_x$ is the maximum damage multiplier.
This is because, of N consecutive hits, only a fraction of them will be from ones with the maximum multiplier.
How to reproduce the issue
Suppose an attack has a damage range of [100, 200], can stack bleed up to 10 times, and is linked with Multitstrike, which provides an average damage multiplier of 1.22, with a maximum of 1.44. The current calculation would result in:
$1.22 * \frac{ 100 + 200 * 10}{10 + 1} \approx 232.9$
The more accurate version would divide the number of stacks by the repeat factor, which in the case of Multistrike support is 3:
$1.44 * \frac{ 100 + 200 * \frac{10}{3}}{\frac{10}{3} + 1} \approx 254.77$
In this instance, the damage difference is roughly 9%. This issue is further compounded when considering more extreme examples, such as combining Ruthless support with Awakened Multistrike support, which only has its highest damage multiplier every 12th hit.
Character build code
eNrlXFlv28iyfo5_BSHgXMzByDKbO33tc6DFsp14i2Q7y0vQJlsSHYpUuNhRgvz3W8UmJUoWJdJSkAvMzMAjNqu-WrqqeiN59N_vY1d4YkHo-N5xjTTEmsA8y7cdb3hcu7vt7hu1__5n7-iGRqPrQSt2XLzzn703R8lvgYYW8-y2S8Pwio7Zce1tPByywKNxVBOeHPZ86dvQen55c927rQkRDYYsus_EyV9AnMuemHtcM9SaMKFeNGK-d0kf_eDUt49rV77Hcu2Ot9BuzeVe0oDGNgugcQQ_rYgFFwjcjCOf6zCgbgg8Y-p4fd_6yqLTwI8nYHNNeKCe7UQpKhj35ujGpVMW9CMaCSH8Oa41wUd0yDp0DH_BNOrGgClJoiY3JFmUdJ2ocu1gLXMrDsLodQj9CWP2nKkhm5JaRHsTsJPBgFmR88TagRO1R9Sz5hLFIr6qtJexGzkT10Gnb6I_ewFNxELiWz-ibuemP6NVJd3QGvBHkQ3RMNbz-dFmdVouuDMvQZIN1ZTFhi7rkkKUIr4PTjR6yQta6URviETVdFNdx3s-9JyIvcI0ZL7xndD3tvDLKww-H0-oyxatlfSGTAxJ1QkhaxV-yayqEpEbqqlppioVxlbsulBk8nyFHdljIQueaOQsOqY4bv3xg-Mt959CiKI0ZFk2ZU0rTOKA0esBz6wetZ04nCHIhXl7ST3a9sN5SMrmOtIbFkA9jRY4xA0MfWb5UIIXhJAGEYsLRE7Sav5CkRfOgJWnrGRNylBVm9fZcdIvS1cZ-HUK9WBMKEfZ92O3JGU0L8yyIhWn0Lc8JVEL46bDvs_IFGUNXp4QikRhcfHmVpB1eHlCzShW78nHQrDZM0lBPDm7mVsja6QhKbqp6IqqFEq4GU1Dx6LuJf3ujOMxDGq39CubC1SIoRcH63AUeVDXipglxSisDV0nYIV8mi4XlzvXfo08GKv9sJBRJNK6lMxppmprJjTWIVKfe9aMwdTW4d55QVLt8xOhNRKQpQcpiHOvB5eV5pmLSVO5zJSFCxsyL5U4nWeeITbUdWwXjFmjU5iV9mjEylX93HhK1joYifMOXou6wr-k2FWLHMuukgyYI0hENXXR1MjaMW-128zGWskVnXbisWA47Y8c5trVqDPF2nRSouKiz_PcpXy_KG6VM0qxVnTJBxrY5calclRVNX-iYb5Wk_WVIiUvF8sMZujAYLOyq5mbwH_E9ZJbja0ZjP04N8bK623g5HkTiKRsGmr4crHH7NhaGNuUNWsbWN2WNQEUc91KHM0ootbXjm8PWSUh1Tn68WQC9QX7vSwfjpOwJHBy06N9YzPxNcRsqQTH8XQZvzhy59SlBcxmCeWlLLGUtwXH-GUxslSCvLSI2TbEJVSFMYwPyTbGpZ8bYBrFE78urAMX1mmqLuqq0VA1Q9NFbS1bmcVuit__6rhuljssjIRkgS8k_CEkrAUA_WfGwN4QSW9oAJTVsS-oBTMRLM0Z6gJgy49GQujScMTmC0vDMBSpoZgGkQxiSsXgmYKrkDdsF6xAwyaBr94X_bAaV5GJaTZEmDhrkmkWzoBv_GeImxFuAYYlanKOGmai8ypb2O8B835MS-MvkJcScOLZcYB1aFmGXpYjLyZjunXGMF6FYYdGVLDTJcw9DRzqRVKyOxkyGlijC0i8pANmV13qug9Qi5PWZEez67gRCzpwD4Wi8cuIBBFR8NFBsoGLv24DxgSa5CmOU0iRaIYXwpiGADnlmRwe136qskr0uqJqqvyr_lNSJEmpEyIqJlzBMkokdVlJLnBnU8cLSYQrVYLrumqKBK80WSdiXTZ0Uf5VEzzfZgANay-J1CVFNOQ60Q1ZrnM8DWJVr6vE1OuaLBkSNCi6VCemaAKgrml1Iks6UCOVDlWiLmkw66xLoKpah9jUQCdRltW6pqhAo-hEV0GOSUBzSdfMOvxU5boq66YMXBqIkBWiE0AzoZ0QWVPquMsnAxoA1WVYO4l1TZIV5JWJUdcIMQ2UIkp1Q0XVDUNCGEUUQYgigicI6A3kCnDqCgETdQ3UA4tAJUUDN8Ii3QBBuBdcV0TQvi7rBrZAWmG7CVZrOkhTNdkAm3RZ0kAy3K7jokYBH6lSHTJQA_EIy3sHtQV3wVzeAPEakECWohWipJK6Diqi4mAQmAliRBEkSKaqgC9MGeyXML1BOZUgD5hY5zEAnShBi5xoJEJxBpNE6GTg1UELE_wtGdBFULlAuo58pikBrUyAg2i6CtqjowHDNEA3g2CPJoFCoCNBWVVHP8mglQQgYAd4TBE17CxNR2zVUMFs04AuViV0uwRa1XnoEU0Fe8Cn0AUQEaCraijYY7IGTtUkFTQk4Gf0FrpDFs3EQYqKfSCDotArQA4BDD0JIw8yiaAuAUVBFNxADTRwN_QtGMajWhJhVQZBALIhKmQMTuhIE_QFH4oyJHTu0OTcTlI8ghTMnYpIUnq2wW9jNr45uutdJD_ejKJoEh4eHDw_PzcmNBr5A_Ydpq4Nyx8fTIAJ8ng_KdP7CHvQhH9aw5PWIPhqfhxddb_RSU-3rbvbgTXVO8Mzm7nSpfm1pZr7k8-D1mNb_vHZ9r4Yfanbv2RnzaZ9Pvrcfddl-29HF6e9wY38VR3EnR-PVnusP6vSR6d7_xTQ00-dlszk97e3rcn9cMjiu_OP4YfBNbtXb4zPwWd70vL35Y7U-xGb15-N93fn7Qfl6a3J_DPdubjttMyz28h2QvvkjIadx-_Xl96VZ31zqac89Ow7vdcZPAZD_aHrfH1rtBXRa393et0gjMTY__RDVluwBlVHl31dt56MlnPb8p8fTtvvotH5Z_1Ktj_Si9i7756djh_vP_14_67tXZ5-8NTu6bfJTb9zFQ_7yqfuu2dGPn-J7t3g3be-ePO21QtY9Gi7BlN-KLLbOjv_0PyovL-Lxk_aif7cPO18HH-764eTj9_a03v75Er1Ly6-nH8W7x-vP158eWRJxx1kPXfEz53CA36F06jAgdLHB4IDrLdJZcaCjD-SITmE2h5Ep2wctqYwFh_XoiDGOcTIf2660fuYuk40xduzE660lCNzn0VJfNlsQGMXUVIG3MXhIDjL5gJupxMsw82LizzDBT-e8_xgPNv4qi3q1MXl5-LeOh9AUhUEJxfGfJ7BPNyTsTNr8FCuOVc70XmprU1dK0xuOJ7lxjY799KZSwbi0gfUlMt5cwTqLYv5xo3HrOpwA2dt3CGc_tT1H6grZVweHacDY34aiCDpdXqCiQBDNsYblyyiNgzoB-cROOkAPXWQWAG_Uqa8KJKJsvzYi7Ih-jcZ0QriKKHOG8KDIHerpE2z4Mmx_jHLOoza7lRoOi6uNcKX9nGC-f2qRi7z_zFLky0OIdsjELIz5WV7E7LFnYTqRq8E-WOW3_sujZzV4Zu_V9XKPO-f61Y8UQ-jwPm6qjPzNyt3Yp65jH1HvF79vpqdDla_v2jfx66HRwDLQbPUXq2IX7HnJf4_FjQ3OIfI2bWYqk1YgFY1LkX8Z4XJBxoILep5-DTLzJct1_dtWE3jtCa7Wc2XAJsx_rP82XVZOBKoZwv9KHlYa9GpfbiT7Z9X82gC3PTsFPaf5dXEd9yr8GeVU_sR3ypPnaqV8mnCjT5NQP9fuLTsnD63ISlt79_cJm3m2Y4fA0cfd2arhuoc7dWjQ848sr15vZXTxN6r5oW9PzsR5NvTL43J2quak_H9MYO6yU6rwM_XVixe-H1-u7p5i9wVMzz9CUv5ZH-C70vgz0RUuuGAv7P9hjhk_OmnD4xOfC9p5jUygUPS_KZAjwbgpUOh1-yd7MHUSkCCvX7s2SxwvKHQ_M722gEdRMw-FFDZvZuADZzvh8LPgHpDdkh-Xfgw5Tn3rIDRkNmLc6D04QSob03LgvmQNe3BXN8bGgUwTdtehrh99s-gNpqvEmyAKYN1XLxbksOxFbS8mzgi7hnhicH82VtppH6Bf16y8edUEy55L932ORQkcS_dhQJ378_-3Uu2eXrs26GgaXuQC65jOUhD9n5GdBgeTlLDvtgJYv0B0evpRXazThND6pSvkH_9LYn_EiI_XZ8K-GiAgNoLc_WFgR_wEzfokD1JNf6FYwF3y_ICd-9vRd2EtwedFwqKjmSG8gJB0vP43O9C4vg9UFZErixGBB4ke2lCCiP6xAQZDLKSw2gktSgE-lx7VcyDp0o-O9FoToJ5denbPewjIemp4xo-H5RmQ5p5hRTSRgp5I4WykULdSKFtpNA3UmTnj0m9mpeFJ35QlYzm3OSFEnF3df7-7mSvNw1hvT6i_wPlJfzfUGj7jrvXj2LMXKHF3GivDaXQnYbRodB8CChuis-a8smQnosdCpDYgtxQG7mmdhwEEMZ7feYyC2qPMLsjLcqaJw8gLiZPlo1_SeK-LP47HyAA4QkdiDU8nxPgvxOPjR0Wphn3yJ6Z67Jg-gWyKnAe4oj9SuHAh7_-RkRF_DfGYT8CPYfRKOVMszDLyl8_U5-CGpiQeNooXDoe7uTOEyTNhTRPNgBJeU3-khNFdgLMNRz70BnpXvNONXw1cFr28qBJoSHo_r-Iui9BTywVm6SY8OKRgrrOgBWo-PdfhrhPRN6f41RDfDwwz4pPdwmqmLQLzyPmCVM_5nFEefhMV-Yc-QfXlzUU5soKhAcWxfOXxbMM14-SGdxx7YzBkBdBrZmGIUQAH2MFFASQNw93vQs8pscLnKuJmW4bEbQKCC3fngp8Ub2NItxmCO3-M50sA5Hd6CO9Rp8lDLk6hrTSpipAXVgHfn2N-qtFK7txp7x1nClbI0i7CrEqQDA3fmLhNkG62pgqDsUpwO-I7505VNuBMtXy3o_CHWQr2SZI16bdzvJXrVw6to9NsnV-7Gw0ULeNCmnLPNveF6_Osm1NV7YF0F4TxLsYQ7fog6LM1irnkbJl5OyiHqm7KiPa1mG8o4kEqdwPr_FjAQsp2XXV5yqv6KfX-bNyP1YtAhXoe7h1SqoybD_70nY1usjbVkh1B9VN3U1iKTtQZWcTQqVylqtbVlttS35166isEkzNcey-qmj8pqqsvXac2TaByA58ULXrC8ilqmPqBt35rk92pJUcZOGvtu8NnCHfDPImcSYJ94Ic3KdNNtmy7fya8OD7LqNeeoR2sIHv0n8qxRWH7OXLJtVEtYM4HOGbvJvYxrOjE34CGl5zgJrgxeMHFsy269bZRZ1xkawbl1ps5Ls2C1JexvWbfxFmWVABS_oqpO-6yXbenE8X1zNmQ3NGT3Qp_xWBVSzp93bmEjaIWH4-ciZKMpX1nLMXYTMWQzaMzb5bFiSL6Ws9swA-Sp6ueNFzybHyF86W03NVZDih9eUhHgzw-0k1AZ8exI9CnXS7J-3b8_uTlKXPkjdTBQs6hk5CPBDPbZWmB8d4gAIQ8UPIqY9r9w57Tm52WEQdNyyFdjY3PI-V4MzvlUH6QAMrcDCv8kAn31mAh36zu2Wgki8OvVCH6-Kn57XlfMWDLg_Fzw_aNIySt7rLoGB0LIJgSzlTZg9V5LjTttKdja8R4Dtw4QqnRPiKwYRZzsCxOE3JXs9KxYJv0oPaUhhJyV7k501lmPmXlxa507ZSXk2--rTkVd5WKr6YRaeL3LypDPPsqwCLALNm3wPvlkI6cVnuyfoc1pXvJcEOeTMjKAN4CfUlfa9wEfA6GrEgu1MGqZkdkIYvsidrL-Wr5OMlC27CllK2JF_lyLMmLaX8uvBtioVqlL9TsqgtQSQtZVizF8HzzLytZBekY-yC-3lbKSdko-CC_WljqSThTzs_-Y79slIs39waMPliwg70wm8ibA-z_LWEUojJum4pX9K2Qnb-nFgR9x1_f2I7EMy47RAw8coj9F5MJnplpxBYvzpswKA_VhWw2a3tsPB0P3tIpIxBG7QqkQTlsXi1r2Ro-jgd_6DUyxzlN7YHgrHorOykpxBp9vmKM0Zd_P6i724HuPxFre3shPU69ewOfnenVKgXIuFXe-IJYGWKXednrbCkSBcSR_gc8lTo46un9hMG0S24JPfi6WTCvLn2NgthLk3TscDlvjuC6aQfRAL7jv9LADOG5PaVD6M12oKCs4vkEwW4YBB--P74I36JS28QXRcVWdUMWa8l7embqmr2jYR-FOC6H299Oq7tq4Q0TF1TFYkQ3dDTt19hEtpxoJ-DJITnK9ejg-VP3v4fe0idiw==
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Start by locating the bleed stacking calculation and the repeat-multiplier handling, then reproduce the Multistrike example from the issue. Done means the calculation reflects the maximum multiplier and repeat factor, including the stated examples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100