PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Minions with Multiple attack forms (like Agony Crawler) handled incorrectly for "Full DPS"

Open
#6,265 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

Each of a minion's attack forms should be accounted for in its full dps calculation, including the (if known) timings or percentage of time it will use them in a standard situation. (IE, 70% slam, 30% roll).

What is the value from the calculation in Path of Building?

Minions with multiple attack forms require you to choose one attack form to be calculated for full dps. For example, Agony crawler has a Mortar, a Tail Spike, and a default attack. I can choose one of these while the skill is selected as my primary skill, and that attack form is used for Full DPS calculations. However, the minion uses its various attack forms automatically, so this never represents an accurate picture of the minion's full dps.

This is especially bad for builds that use many different minion types (Golems, Agony, Purity), as each of them is miscalculated.

How to reproduce the issue

No response

Character build code
https://pobb.in/O-8OMD8XFZV5
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by loading the linked character build code and reproducing the Full DPS result for the Agony Crawler and other minions with multiple attack forms. Trace the existing minion attack-form calculation path and determine how attack timings or usage percentages can be represented; done means Full DPS accounts for every applicable attack form rather than only the selected one.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.