PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Minion instability and total dps inc. ignite

Open
#6,232 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

In the scenario where you have a minion with minion instability enabled and with some chance to ignite, pob should add the average damage value to the ignite dps to derive Total DPS inc Ignite

What is the value from the calculation in Path of Building?

What is actually happening is, pob adds average damage + damage per ignite to the total dps inc Ignite.

How to reproduce the issue

Add a minion like zombies or srs, allocate minion instability, add combustion support to get some ignite chance and check Minion instability dps numbers on the left side

Character build code
https://pobb.in/bTxSAfVgjEZA
Screenshots

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the calculation with a zombie or SRS minion, Minion Instability, and Combustion Support using the linked build code. Trace the Minion Instability DPS calculation shown on the left, then verify that Total DPS inc Ignite uses the average damage and ignite DPS once, with the corrected value matching the reported in-game calculation.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.