PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Calculate DPS of skills which have a partial uptime
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
enabling things like Berserk, Vaal Haste and other skills which are not up 100% of the time gives a poor indication of the builds overall DPS.
Describe the solution you'd like
When enabling a partial uptime skill (like Berserk), POB could calculate (or provide manual input) the expected uptime of the skill.
e.g if skill is up for 10 seconds and then down for 10 it would have an uptime of 50%, so maybe a box next to the skills with an "uptime" percentage where a user could manually tweak it could be a quick solution.
Berserk uptime calculation is being worked on; but i saw no indication of this being used to uptime the Total DPS
https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4902
Describe alternatives you've considered
You could just enable it and see how much you have with and without, but it would be neat to see some average automatically calculated into POB, as of now putting things like berserk and vaal haste in your build will give a twisted view of your builds DPS
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing pull request #4902, which the issue identifies as related to Berserk uptime calculation, and trace how partial-uptime skills currently affect DPS. Define how calculated or manually entered uptime should be applied, then verify that skills such as Berserk and Vaal Haste produce an average DPS rather than only their fully enabled value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100