PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Phantasmal Smite not increasing damage

Open
#6,037 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

Phantasmal Smite grants [Aura grants 5% increased Attack and Cast Speed] at 20 quality.
when switching from superior to phantasmal there is no visible change in dps or damage.

What is the value from the calculation in Path of Building?

Smite Aura should now also increase attack speed 5% +(any aura scaling)

How to reproduce the issue

select smite as main skill
set quality to 20
change quality to phantasmal

Character build code
https://pobb.in/W-WWRS0yKr0P
Screenshots

There is no change in damage or dps when using Phantasmal
2023-04-13 15_54_53-3 21 - pre mageblood - current (Ascendant) - Path of Building

Superior
2023-04-13 15_54_43-3 21 - pre mageblood - current (Ascendant) - Path of Building

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the linked PoB build: select Smite as the main skill, set quality to 20, and compare Superior with Phantasmal. Trace the Smite calculation entry point and verify that the Phantasmal aura's 5% increased attack and cast speed is reflected in the displayed damage or DPS.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.