PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Buff/charges chance and maximum in the calcs

Open
#5,974 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

I'd like to be able to see in the calcs chance for gaining buffs/charges and also related stats, possibly buff effect/duration mods, but at the least the maximum value. I'm speaking here from the position of the Discord mod who manages dozens of different builds and helps the new players with their builds. It is very bothersome to search where Fortify comes from, for example, as that can be the support, mastery, ascendancy or eldritch implicit. Same with maximum charges, as there is the tree, ascendancies, implicits, annoints and such. Also if the build maker overrided charges in the config, for example, it is hard to see at glance if we have the source for said charges.

Describe the solution you'd like

When I have a chance to get the most influential buffs (Fortify, Elusive, Onslaught and such), I should be able to see those chances summarized on the calcs tab, preferably with modifiers to duration and effect, and of course, where those come from when I click on a calc line. Same with charges. Maybe enable those frames when the buff/charge is checked in the configs.

Describe alternatives you've considered

Currently I just remember where the buffs can possibly come from and look there manually.

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the calcs tab and the configuration controls for buffs and charges. Identify how Fortify, Elusive, Onslaught, and charges are currently represented and where their sources are exposed. Done should include a decided scope for summarized chance, maximum, duration, or effect values and source details, with corresponding tests or reproducible build checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.