PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Enabling "Include in Full DPS" breaks the gem comparison window for the main skill
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Check for support
- I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the behaviour in-game?
N/A
What is the behaviour in Path of Building?
When turning on "Include in full DPS" the "new support gem window" comparison seems to compare the main skill to the extra skill enabled.
With Orb of Storms enabled:

With Orb of Storms disabled:

How to reproduce the issue
- Create a new character
- Add a Main skill and one set to "Include in full DPS"
- With the Main skill selected add the Stun support (Since Stun support shouldn't alter anything it's easy to see the bug)
- Notice the wild comparison numbers
Can also import the attached pob and enable the "Enabling this bugs out the Gem comparison window" socket group and see the bug happening with the main skill
Character build code
https://pobb.in/YXM10r2l6M09
Screenshots
Tested also on a new POB. Arc included in full dps:

Arc not included:

Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the gem comparison window and reproduce the issue with a main skill plus another skill enabled for "Include in full DPS," using Stun support or the linked build code. No source files or tests are named; done means the comparison for the selected main skill remains correct whether the extra skill is included in full DPS or not.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100