PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Managing Passive Trees Quality of Life

Open
#5,900 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

Most of the time builds use the latest version of the passive tree, but in the cases where they do not, some quality of life improvements to the Manage Trees popup would be helpful:

  • Allow multiple trees to be selected to be deleted at once
  • Mass-update all trees with one button to the latest version
  • Auto-resize the list of passive trees to match the tree names (currently is a set size, unable to be resized)
Describe the solution you'd like

In TreeTab.lua, update the function OpenSpecManagePopup to resize the window based on the longest tree name in the list. Would need to pass the list of passive tree names over to this function and calculate the max length from that.

Add functionality in PassiveSpecListControl.lua to select multiple trees to copy/delete at once (for those builds that have multiple trees for stages of levelling/budget/etc). The mass-update functionality would probably also be added here.

I have some basic Lua knowledge, so I will try to work on this myself, but if I missed a file that would need changes or if these suggestions were already considered and not wanted, please let me know.

Describe alternatives you've considered

No response

Additional context

Example image for current tree window:
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading OpenSpecManagePopup in TreeTab.lua and the tree-selection handling in PassiveSpecListControl.lua. Review how passive tree names are passed to the popup and how copy/delete actions currently work. Done means the manage popup sizes to its longest tree name and supports multi-selection plus mass deletion, copying, and updating to the latest tree version.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.