[dev] Winds of fate should change DPS, not average hit

Check version

• I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• I've checked for duplicate issues by using the search function of the issue tracker

How is Path of Building expected to behave?

When you deal 0% damage with non-crits, your average hit damage should not go down. It causes issues with ailment estimations. Instead, we should affect DPS.

Technically speaking, on average, it is true that the average damage goes down. However, in practice, we use average damage for both average damage per hit AND for average damage per hit that does damage, which is relevant for things like ignite, bleed, shock, etc.

How does Path of Building behave?

0% damage from non-crits when you're at less than 100% critical strike chance lowers the damage of average hit, which breaks ailments and leads to misleading breakdowns for things like burst damage, even though the final value is correct there.

How to reproduce the issue

No response

Character build code

https://pobb.in/MCD6Rlt0HAig

Screenshots

No response

No source file or test is identified in the issue. Load the linked build code, trace the DPS and average-hit calculations for non-critical damage under Winds of Fate, and compare the ailment estimates and damage breakdowns before and after the change. Done means non-critical damage no longer lowers average hit damage while the final DPS remains correct.