PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Take into account potential of crafting when searching for better items in Trade
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
Some good items have open affixes which would make them great if crafted while others are crafted with a mod which is not ideal for your build and could be replaced.
Describe the solution you'd like
Ideally, empty suffix / empty prefix would be added with weights corresponding to the ideal craft.
In the ideal case, it would take into account already crafted mods but I know that is quite difficult to get right. Corrupted vs non corrupted is also a hard thing to account for.
In the simple case though, a non crafted item with potential could still be an easy win.
Describe alternatives you've considered
Manually edit search after it's generated.
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by tracing how Trade searches are generated and how item affixes receive weights; compare open prefixes or suffixes and existing crafted mods with the requested ideal craft. Done should mean generated searches can account for an item's crafting potential, with the supported handling of crafted and corrupted items made explicit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- desktop, search
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100