PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Other avoidance/crit reduction suggests crit chance reduction when it's extra damage reduction

Open
#5,417 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: accuracy good first issue
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the wording ingame?

Reduced extra damage from critical strikes (Watcher's eye).

What is the wording in Path of Building?

Crit reduction
This suggests reduction of enemy crit chance.

The true source of enemy critical strike reduction is Defiance banner which is not listed here. I believe crit reduction should list defiance banner (and other possible sources of crit chance reduction) and the watcher's eye should be listed as crit extra reduction (or something along those lines).

Character build code

No response

Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Search the repository for the strings “Crit reduction” and “Reduced extra damage from critical strikes”, then trace how Defiance Banner and Watcher's Eye modifiers are represented. Done means the labels distinguish enemy critical chance reduction from reduced extra critical damage and the relevant sources appear under the appropriate wording.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.