PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Arcane cloak breaks a lot of calculations if used with negative unreserved mana

Open
#5,411 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation good first issue
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation ingame?

If you have "negative reservation" it should simply acts as consuming 0 mana rather than a negative amount.

What is the value from the calculation in Path of Building?

It assume negative mana breaking damage and max hit calculations
image

How to reproduce the issue

Reserve more than 100% of mana
See broken calculations

Character build code
https://poe.ninja/pob/Mi1
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the linked character build after reserving more than 100% of mana, then trace the mana reservation values used by damage and maximum-hit calculations. Done means negative unreserved mana is treated as consuming zero mana and those calculations no longer produce incorrect results.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.