PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Calcs soul gain prevention duration

Open
#5,373 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

The duration mods for vaal skills are shown under the calc section, along with their modifications and rounded up to the nearest server tick, but the soul gain prevention base duration and modifications are not shown there. Would be great to see them added (rounded up to the nearest server tick of course).

Describe the solution you'd like

Extend the skill specific stats for vaal skills to include the soul gain prevention duration.

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by locating the skill-specific stats calculation and display path for Vaal skills, then compare it with the existing duration modifiers shown in the calc section. Done means the soul gain prevention base duration and its modifications are displayed and rounded up to the nearest server tick.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.