PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Add support for buff/debuff expiry rate on player and self curse

Open
#5,069 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

See https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/4703

Also includes effect on ailments on self, and includes poison expiration rate, but does not include temp chains
This isnt even supported for self skills (like molten shell) but is applied to enemies so can extend this at some point to include that

When using boneshatter (trauma) or other buffs e.g. shade form it can be beneficial to run self curse temp chains to gain a longer.
https://www.poewiki.net/wiki/Expiration_rate
https://www.poewiki.net/wiki/Temporal_Chains

Describe the solution you'd like

Adding support for it like is done against enemies while affected by shock or enemy debuffs.
image
If possible adding support for the reflected curse mods would be nice as well.
image
image
image

Describe alternatives you've considered

No response

Additional context

This needs to apply to both calcSkillDuration() and the general skill duration calculations.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the referenced pull request and the Path of Exile expiration-rate and Temporal Chains references. Trace calcSkillDuration() and the general skill duration calculations, then verify that player and self-curse buff/debuff expiry effects, including reflected curse modifiers where feasible, are applied consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.