PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Incorrect Interactions between Eldritch Battery and Mana-based Conditionals

Open
#5,066 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

While using Eldritch Battery and any mana-based conditionals, either POB should assume there is no realistic way to trigger the mana conditionals or provide a warning to the user that it is unlikely that they would be able to trigger the conditionals.

Note a case where POB should be calculating mana consumption is when using an aura with Divine Blessing Support, and the following conditions are met:

  • Eldritch Battery is active
  • The user has unreserved mana
  • The aura cost is greater than the amount of energy shield, but lower than the amount of energy shield + the amount of mana (aka the user can still cast the ability)

In this scenario, an Inspiration Charge would be generated, and Arcane Surge Support would also trigger (assuming the amount of mana consumed meets the gems requirement).

What is the actual behaviour/value?

While using Eldritch Battery, POB assumes that any mana-based conditionals are still valid and able to be triggered with the build's setup.
Such conditionals include, but not limited to:

  • Inspiration Support
  • Arcane Surge Support

When using the above supports with Eldritch Battery, POB will calculate the DPS increase as though the user has spent enough mana to trigger them.

How to reproduce the issue
  1. Allocate Eldritch Battery on the passive tree on any class/ascendency
  2. Add the following line to the custom modifiers:
    +200 to maximum energy shield
  3. Add two of any 50% auras to have 0 unreserved mana (e.g. Determination and Grace)
  4. Add Lightning Conduit to a new skill group, and ensure it is selected as the main skill in the side panel to observe the Average Hit.
  5. Add Arcane Surge Support to Lightning Conduit, and observe the Average Hit Increase.
  6. Replace Arcane Surge Support with Inspiration Support, and observe the Average Hit is higher than the number observed in Step 4
Character build code
https://pobb.in/hSHLJmEMRqeA
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the discrepancy using the linked character build, Eldritch Battery, two 50% auras, Lightning Conduit, and Arcane Surge or Inspiration Support, following the listed steps. Trace the calculation path for mana-based conditionals and Divine Blessing Support; done means the planner no longer treats these conditionals as triggered when the setup cannot spend the required mana, while still accounting for valid mana consumption.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.