PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Reservation mastery calculation bug
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
The reservation mastery "8% increased Damage for each of your Aura or Herald Skills affecting you" is currently bugged and calculating a DPS increase for curse-based auras which do not 'affect you'.
See my post on the officlal PoE forums here with my in-game tests:
https://www.pathofexile.com/forum/view-thread/3308443
This causes a significant difference in the POB DPS from that mastery and the actual in-game DPS (it is half as effective as POB shows for my current build)
Edit: My post on the PoE forums got a response from Mark_GGG confirming that curse-based auras should not affect this mastery. It's very easy to test in POB that this is currently not working properly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by reproducing the reported DPS difference in Path of Building with a curse-based aura and the reservation mastery, then trace the mastery calculation and its existing tests. Done means curse-based auras no longer count as affecting the character while eligible Aura or Herald Skills still do.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- backend, game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100