PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Negative damage and duration

Open
#4,996 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation good first issue
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

You can't deal negative damage or duration so expected to see zero here.

The only notable stat is projectile speed which I think is capped at 1%.

What is the actual behaviour/value?

Some stats can become negative when they shouldn't e.g. damage or duration, regen, etc.
image
image
image

How to reproduce the issue

Add alt quality defiance banner and ashes of the star and observe negative duration in panel.
Add enfeeble with 500% curse effect and see negative damage on player.

This likely effect a bunch of other multipliers and should likely apply to all reduced and less multipliers capped to x 0. Except maybe some special cases.

Character build code
https://poe.ninja/pob/EgI
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the provided PoE Ninja build code: add alternate-quality Defiance Banner and Ashes of the Stars, then try Enfeeble with 500% curse effect. Trace the stat calculations that produce negative duration, damage, regeneration, and other reduced or less multipliers. Done means invalid negative values are prevented while legitimate special cases remain correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.