PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Eldritch Implicit Mods not removed when influence is removed
Open
Nobody has claimed this yet.
enhancement
good first issue
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
Eldritch Implicit Mods not removed when influence is removed
Describe the solution you'd like
Remove the mods tagged with {eater} or {exarch} when the corresponding influence is removed
Describe alternatives you've considered
No response
Additional context
removing the mods when the item loses influence probably has something to do with setDisplayItemInfluence in ItemsTab?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at setDisplayItemInfluence in ItemsTab, as suggested in the issue, and trace how item influence changes affect Eldritch implicit mods. Ensure mods tagged with {eater} or {exarch} are removed when their corresponding influence is removed, and verify that the remaining item state is correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100