PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Duplicate skill gems in full DPS causes incorrect DPS calculations

Open
#4,682 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

DPS Calculations should accurately show more/less changes to the skill.

What is the actual behaviour/value?

DPS appears to inconsistently either show the final calc values, or an impossibly large more damage multiplier.

How to reproduce the issue

If you wish to observe from nothing. The properties here appear to be slightly different. Ballista totem needs to be present as a link for a variant of the bug to appear.

  1. Add a bow to an empty build.
  2. Go to skills tab.
  3. Add 2 instances of Toxic Rain, one without links and the other with ballista totem. Enable "Include in FUll DPS" for both
  4. Start to add support gems to the first Toxic Rain.

In the PoB provided below, ballista totem does not appear to affect the outcome of the bug.

  1. Go to skills tab
  2. Select Toxic Rain (6)
  3. Attempt to change an enabled support to a new gem.

Steps to temporarily fix the bug from the PoB provided.

  1. Go to skills tab.
  2. Select TR Totem (5).
  3. Disable "Include in Full DPS."
  4. Switch to Toxic Rain (6).
  5. Attempt to change an enabled support gem to a new gem.
Character build code
https://pobb.in/hPql3eZ74-8F
Screenshots

Expected behavior
Current behavior

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Import the provided build code from pobb.in, open the Skills tab, and reproduce the issue by enabling two Toxic Rain instances in Full DPS and changing a support gem. Compare the displayed more/less damage changes with the expected behavior shown in the screenshots; done means duplicate skill gems no longer produce inconsistent or impossibly large DPS multipliers.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.