PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Importing passive skill trees doesn't update pathfinding algorithm's tree.

Open
#4,366 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

After importing a passive tree using the Import Tree button, if I try to allocate a new passive, the path PoB takes to get to that passive is found as if the tree doesn't have any passives allocated at all.
After I try to change the tree in some way, the pathfinding updates the tree it uses.

I've also checked if this is a issue specific to my build, but I've reproduced it on other classes as well.

What is the actual behaviour/value?

PoB should take into account the imported tree.

How to reproduce the issue
  1. Import a passive skill tree using the Import Tree button.
  2. Allocate a passive skill.
Build code
eNrNW21T4sgW_rz-ihRfL2g6nVdL9xYIKjuoDKDj-MVqSAMZQgJJA4Nb-9_v6e4g0RFssrdqd6zCJJyX7nOe5_TpjnP235_TUFvSJA3i6LyEjvWSRqNB7AfR6Lx037usuKX__n501iZsfDesLYKQf_P70W9n4loL6ZKG5yUX1BhJRpQ9bEzhZ3g2IxEb0zi6IT_i5Cr2z0u3cURLWp9EfsA2d4OQpOktmdLzUn1BwyBlJY2kAxr5F9tvLsZkOgPLJW1KgqgbDyaUXSXxYgajLmnLgK5uYh_kmjftu04v5zqI8q5h6L-dtUOypkmXEaal8HFeqkIEyIjWyRQ-wRoJF2AKYXSMsWvrnuN6yCqdfKzcnVHqvyoZx1h3d8q2E9oYDumABUt6kQQMZhUNth71XXqHyt4sQhbMwoAmn8tf_2Ia6TuFezEjYb3dfZXFOj5GnoVc3fZcw96vF7PPh_MtYONaCCEt4IXrNkdRwGhB5XYcpHH0N-aXV92doUUYAo3UZONpP4gKReOGROQiTrcx93ZJtoIhfSO5cziNrppcB4ikJslH2aYJ0J2pKfDBHqSQeejSQQwl5RAfh6jk5lHMWQHNRreIQgFHXZbkqgPemXU6z0s6zi7BOv25tefus5eX9Nxdgs1oOwnT3O11GTOxhnw2X0HnxnV7W9Z1rB8bu9cAEUtYa4IpCW_Iz2C6mEJd7ZEJ3XpDFtKPMXJMW4dPax8ctjre7mjDwjM45dLNaLCNOdpn9z5KaEqTZW7B2ufhrUoGHZVlgit26Cg3edM7Nh13n3yL0sH4Chb3DmG5ABwbyHBc3TEMx8P7yPeqYmF7b8i4cD5keyn9QcRMbKppvA-Yqx97jo5Mz7Cwg9E-I2-DB7HbJ_x3IveNJL5C3YhoMlp3xwENFaRFlPMqStHOK7ydvpLKx0HYrbokab4UYHf_bKR4fiII7VxPbyg0MKDiU9WmrZ3EP3hbGB6mVk2m8SJRzIgUzk_B292ojtdpMICWRrTEHeovBmqV87W9vYmXdAroF-0x9ObbuO1SrYXQ1avOHMyG4UEaVcbIYFKP_RE9yMnhGt3FbAY1gANGVe8ySCDKaZBbjCu7O7ut9B3sXC7ITKWP5KxSdbCVVnbQCkZjFkFbq-7lnYr6XMYkTt-7sVXElV1cQouu1J-34xWYHPPNb3qYNLQJ2-qzcxwJjV7WyvbfiCs5aET-IuEYVfbxXuNXN2cn4nSAXzWnszhh4uEFCQepMNmMZgumRWJfPw3SwXN_MRzy7XsJXCTi6KFxedm46DUfGtko8irpJAjD52gx7fPtrfy9LStdKiqVNojDkMxSCjv_IQlTsB3AZZfrdqE8D5iSPDRx2amAijQspoMkgCCqCPPdsNKQxfmCiiTf-SsJQlZISNUD1lvPKEdAqhqzrOypSIu9vpKk3JyrTVAcAqilgQ7IWknytcNQkm6EtBqEfAVUi9oNEEEunmrysJwlQX_BFNEmdhVK4-CttNIE8z2hIjvUBLOuRmkQWRunIputGGqghMZCOW11OqQAd0Xai3Iid4ayWG4K45ngWqqlUDGv6DStrWEFuuThfXcMNCUMgEinLX762ot5HSYDRpOWPI3NnL0xc15iyQIe-nRIFiF__nVBwoCteaHPPc1MGPAwHccr3slIM7wEpJCaVkt-Uw1ZZoH72DiV8-fTEMe0VdEJinsxSXFWG0SDcOHDpjVbY18HHJI-913SRvxc9yJeRLDaREHIj6RJP-RxlJN4Z5pb5Y5_O4OhZLJXYdwnobG1vZ1XXgBtTIo1pSmr7YAlJLymYQDr2lzOsSkKhQhSJtsmCRPTGdEp__aGMuITRk6aDOJxwoNyIkYHVx_bFJF_N7NX09twDWQc4IqvftzUdpCatChhJ9392zOAPs1AdTCA_mKwrkY-X9DSKtxlX_MDFtiEQYS7VMbk_5KfdkIHgdwN7snNR4nIaeYGCAlaTKcx0LVDyYwm7xOUXQnO9xJKNSJDKUyaGYngRmMBC6HheaDJWmuQJFy_eTHCp4V5LlLg_jpbO3j2Imil4MJ0sOuVDQshVDZdV3fKtq7rRhkhExll0zIMp2zZ_BLzB7Zhe2YZm7rulS3kWnbZMD3XhE_sOGXsGWAGm7Ztw7VjWGVL91y41pEF17arY3BiIRgQgynl3gMhJ3vFw8drZjhp-LA--7d8oCfyyX2nJS5-GzM2S09PTlar1fGMsHE8pD9hX3w8iKcnMzADkaqIYFe4o5Mq_KuNvtYbycT_PqaVWWUWtP7oruY_H9P5U0-34t7TelYb3j1NkrEx77ceH1uY3nmjr9WqcHyy8Xwm3yqlm2xBBn5JReEsYNPZZAG5GLKAbdcxs9BDWL2ybbl6Fv5NyLdhNnQd6WVIGdazLJquid0y8hxIS5YuDzteliiZOplSCyx7Wb6RpcMnmHcBDdg2wCbGhpkl1sLcskwpch1IqUysRIlnmv9sipuQ4m92pTLT_cqkOp-FVeP2qt9tGA-uNV2juy_p6sqefvFuJy_PkPL1ypok3l3fr_cvkjv4uXgOGnpjfU1S94s_YH_UPfzjkq569y2jBi7OD4fDTeBrFwS66WAUqaDiT8vWDVxGtm2af5X_tA3LdcumY5vGX6-AMQyDc8zUMcpggzwd8GEZ2MkQBIkzUJYb17TcDFISDHlgIcPcZM5AJrYk0iQgkIXNDd8R5kiT2bcd3Sx7hm5nMJRgkQPPQ1ICSk5BQknCzfQQWASDACIJWwlV08RgMw9hCTqBe9PSMeauuHlH50wQKJSYNiwPvkXIdsAMxjBrMMWfOzaMVWIaeS4EAkyCDLZhnGXJPIlvQ5fM45iW3DANBLqGxy2bnm2gfwrV7bBvj--8fqLPvMvrb5WZiTxMb8YXE7_Sa1e-Xsyn9zfXgNLLO6f-Hfv13nI1vp1ctgbulx9G9YcXutZ8tSTISln6ZakP20HDuyPP6NFNesHcu53r3Zdqf_499ufAlqVNklu8HKM1btWf7nUWzSeR7_kJqs9fek9frv1ZLV108Nfe5eV192tlQq97bOXfV6uTRsNg1L5adtzDmdIijB5GlTw5ym-I844qkiSCHlkxEwyQJMnBPgO8wLcAfB7N0luGVwFGCb086N4ALVcks3VSQkmgXEJPssJElmflaZqnpkSqJGSGXbkCCGS7XD9jkqDAmwVAkEWyTdA1q-GCPQLRG5ZIGmd0lSuCCKYoF5IZkuSSqIbDgyNpKWs-l5DVIVvoBXdkWRKF6p_izteHvv3Ndu99v3YDK8Lt8IFzRHfcpjeqdY1-a9hxgQNL-7FVbz3Zsz9eOMb_QGt90vbvDMabhkqzG9B140sH27OwXnMnVy9-_btvjG_DBF1cpcM1C3sDsbLMX_rPD81nck2YY678B4xg4eWcs1jy2Gt7nY6dtpa9p_myM9Ub6KIyc90v0GxMaGPmje_cajWJiXf9s1a7TR4LNh_aDewp_-0EkjjaS6BfK3KuFh9KoKx32sMfuZ4KPEv6ZIug4IAkbdbKCpxLQgn65HmWp0-2TAnSZfSRdUPQRzJVUidPwF8JJJj9LyeQdxu9IVCnIwiEa6j_EYFWT6yZJ9Ci4fy8_WpPW379_uU56QABgRjN5yeM7OR26T0KAuFlcE3maSuphPMlEG4594d30LptCASL1cEEOjvhGyx-cRszKo6f-cPNjdh-PQR0paWUJINxlyW8dX-J4-n381LFssxj27NMA7u2y6scP_m4poQBB183tlw4Ozaxs1MTRlg9AB4m4lhos4Hkgo_cqmsfG4ACx7EcQzfkKZDYlmYbwfwGd5FS-ccF32ArGUfice6shYuKY6VsA94hsGVen2qdaqdxdAvz4gJH18FoHJLI12oh8enRRUKGgKNTjY_rCPaww-Dnqcb_Pm7PTXcxVLnJDoVONUM_yjJyql1VXn-ORKg6dH6qmeZRczoLg0HAZdDRn4yM0lMiXtP99R-sWxqLtc1pgNYhLIhGIrd8TrI4hvHmpYAMj8ZPN5jc8W9eCGTR3BPJfAA_stldkZlW7a_TlISanJRmbR1lb0o-VH2vZqip_TKLN1K1OGZpwQF9NJdPBlWjITtQ5RIq10TDSkMyPhoSLhZetSAY_yc1s9gg7WLe7OLRRJ8k-CM8fZKBaxpOKTvU0QdIsov4-QR-V2G85K8yDzeMi7MIFfFnFsMCKoY88_P0qAT2ULMfwavgxJXqjlVgPAVqIP7Mjb_W5KusA9P3cZQL4csqoqRESZVEFJqnVTisRoG828WYhIvBFx-OMrN42S-AaVQ4-FgFEKaKUIFh_43mRzGTxbNgF0Bl8TT8DbiolmSuq8gaddECkevAfkCtEzi4UOwMb8FyoZ7PItPBCnFCxdNgFo6WVWQ2KnwpDvJPhlSdLsIP1ja554QtozhSEHt18SdtcTQMRiBxdvL-f8j9Dw5Bqko=
Screenshots

Expected behavior
image

Actual behavior
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the Import Tree button, then allocate a passive and compare the path selected before and after another tree change. Trace the import and passive-allocation entry points to find where the pathfinding tree is refreshed; done means imported passives are included immediately when calculating the next path.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.