PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Speed and Physical Heist Enchantments don't seem to apply properly (Weapons)

Open
#4,221 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

Heist Enchantments should be calculated and results are shown.

What is the actual behaviour/value?

When selecting a Heist Enchant on a weapon, some of the relevant mods do not seem to be calculated and summarized on the left hadn side panel. E.g. a Physical Bow with Physical Modifiers Enchant.

Attributes seem to work with Omni, but nothing happens with Speed and Physical Modifiers.

How to reproduce the issue

Craft any item and apply a Heist Enchantment onto it, currently only noticing this issue on Physical and Speed enchantments as I use more regularly as opposed to other Heist Enchantments.

Build code
https://pastebin.com/NLPz6cqG
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Reproduce the issue by applying Physical Modifiers and Speed Heist Enchantments to a weapon, using the supplied Path of Building build code as needed, then trace the weapon calculation and summary output. Done means the relevant enchantment modifiers are calculated and shown in the left-hand panel.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.