PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Undo deletes all currently equipped Jewels

Open
#4,162 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

Using the undo feature (CTRL+Z) should not wipe the equipped jewel list

What is the actual behaviour/value?

When there is only one change in the undo stack and CTRL+Z is used, all Jewels are deleted from the current build.

It seems to affect all Jewel types (Cluster, Abyssal, Crimson/Veridian etc.)

How to reproduce the issue
  1. Load up a saved build with at least 1 socketed Jewel
  2. Make a single change. e.g. set any single equipment slot to None or equip an item.
  3. Undo (CTRL+Z) the change
  4. All Jewel sockets become unequipped
Build code
https://pastebin.com/n964bZ4w
Screenshots

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Load the supplied build code with at least one socketed Jewel, make one equipment change, and reproduce the issue with CTRL+Z. Trace the undo path and the equipped-jewel state, checking that undo restores the prior equipment without unequipping Cluster, Abyssal, or Crimson/Veridian Jewels. Done means the listed reproduction steps no longer delete any equipped Jewels.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.