PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Configuration toggles

Open
#3,989 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

This is related to the new ascendancy related jewels so i don't know if any developer is already solving the problem.

The first problem is being unable to pick nodes from another ascendancy which is understandable.

The second problem is related to Configuration toggles:
eg. I pick the node on the Slayer "Bane of Legends" which adds a "Have you killed recently" toggle, when i remove the node the toggle disappears, i have no way to see that and similar toggles if the nodes are disabled.
However if i go to Slayer, select the nodes, enable the toggles, and then go to another ascendancy the the now hidden toggle remains toggled because it shows the dps increase.

Describe the solution you'd like

Showing along the dps (if any) the dps when related configurations are toggled, see example (on which the node is toggled otherwise i wouldn't see the green number)
toggle

Describe alternatives you've considered

Having a show all button on the configuration page, not sure how feasible.

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Configuration page and reproduce the Slayer "Bane of Legends" scenario described in the issue: enable its "Have you killed recently" toggle, then switch ascendancies and observe the hidden toggle and DPS display. Done means hidden configuration toggles remain discoverable or their DPS impact is clearly shown, with the proposed "show all" alternative evaluated.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.