PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Implement Ancestral Preservation Notable
Open
Nobody has claimed this yet.
enhancement
good first issue
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
2nd and last mod not parsed
30% increased Totem Life
Totems have 10% additional Physical Damage Reduction
Totems gain +40% to Chaos Resistance
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Use the three Ancestral Preservation modifier lines in the issue as the reproduction case. Start by locating the notable or modifier parser and its existing handling for this notable, then run the relevant parser tests if present. Done means all three listed modifiers are parsed correctly rather than only the first.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100