PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Skitterbots applying to Storm Weaver
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
The Storm Weaver notable has:
Enemies Shocked or Frozen by you take 5% increased elemental damage
When I have skitterbots enabled, this part of the notable is being included in the damage calculation, however it shouldn't be because of the by you keywords. The skitterbots are shocking the enemy, not you.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Storm Weaver calculation with Skitterbots enabled and compare it with a character applying Shock or Freeze directly. Trace the damage calculation path that handles the notable's “by you” condition and Skitterbots' shock contribution. Done means the notable no longer applies when only Skitterbots shock the enemy, while direct player application still works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100