PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Full dps for Gems within the same linked sockets.

Open
#3,564 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

Frostblade has the 2 components, Melee and Projectile.

With hydrosphere I hit bosses with both components.

Its hard to find out optimal gems, since im only able to Sort for the dps of only 1 of the components.

And including both in Full dps still sorts the gems dps, while its only applied to 1 of the gems, not both.

Describe the solution you'd like

Have support gems apply to both components and sort by full dps

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the support-gem handling and Full DPS sorting paths, then reproduce the Frostblade melee-plus-projectile case with Hydrosphere. Done means support gems affect both linked components and sorting uses their combined Full DPS.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.