PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Perfect Crime Saboteur ascendancy notable gives damage when it shouldn't.

Open
#3,521 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

Perfect Crime should give damage only when using traps.

What is the actual behaviour/value?

Perfect Crime is always giving damage. Even in completely new build hovering over it shows it giving damage.

How to reproduce the issue
  1. Make new build.
  2. Hover over/select sabo and allocate Perfect Crime.
Build code
eNrFW1tz2kgWfvb8ChVV-7YBWnel8Ezha6gyNms5ycxTqpEa6LFQM1ILh_n1e7oljMxwOcje2jxkhPjO_fS5NJnebz_nibFkWc5Fet4i7W7LYGkkYp5Oz1tfn24--a3ffv2lN6Jy9jC5KHiivvn1l7OefjYStmQJ0LUMSbMpk9_WnKwfwGlBUzljIh3SP0V2K-Lz1r1IWcsY0zTmcv0pSmie39M5O2-FMxqLl5ZB84il8WXtCzoWkhVZy5hTnoYiembyNhPFQstecvYyFDHgBsPRw-NTTTJP65JB8bPeKKErloWSSiOHv85bfbCfTtkXLoEVTQrg4_ik7RLTcv1W5yDRFZ3D3yfQhQvG4lc8aVv1P_9_InDCWzpzH3KUsevJhEWSL9llxuXljKbRxhPEa1vuPtom-GGRSL5IOMs2urV9_4Ah2xK63X3gJyFpcjUKN1jiWm3TtL39OjWnEZs826vRdy5nFwkE4kQJim4wTblkDQhHgucibWhTnWyvWZdiPubpyVatyfrL6Slk_YzRh0mZpY805kX-Su3to7nIoDg98eg5ryXOPvCQpvRS5Jt4envz8Y5P2BvoXqbXIQ73CIUHh1RqjlgGNVXiCJSyJxGEcnMqib1XY_ZXHRjsDdwV-7k55NYBdnXgXuUGqcRxqwOJ4-zXbikkdDmcHze9wTtQqaPPCjtIIxzTr2nGcpYta4V6P_u3BFVcMWVRET6yKUNaesdYNLuF_vxIJcNl5UZ786BzFBblHAXc5RwTR3CCcxThlnPawSHwie75TrMYUSxSlk1X4YyzBIHWvqyToHxaJ0CmQ53kRLuvlzSvHy7iHramhOOSg0FHBYKYbY0GzsdRjDLxpxqKktPI-tlcFBkygiUYZfJotsp5BA1az6mPLC4iXOl6ne2GYsnmcCb0WAhT9iYwe1toAvP5luGHDEqSkyj6UtLo-UrEU3aSkNMpwmKxgMqg8gtLd8Mz8HLOa03zk4tAP8A6cUkXmAlKHUKsgA0aLeCOT2cyhS0PL2WLBG_LjIr8BGM2cLSImyJJUJNp-MzfIiUdJ-yz0f1JnDENJpO9k91IvIAyM7X_5ogDWUMP6WZ62TuX3GQs_XuF5v8GjhJwncZFprIbLWOb4p9ieh19P6CeBvOFyKR-eUmTKNcsB-mikEaqd_tcef5HWszHarUr_7upLnXknOfRj3ExmahlvwXKZPqa4vrm5vryafDtuiIJma5xRiSShC5yBtt_ypOWweMqzCFU9Ugi0LBEVgv-cSz06yjj4L7jULUBIlTVe_hxnFqOETCIA00Y1kVPqwVTEc9xXqrK43Gs3mkRuHIVxZill12M01lEVwjc67iCwF4nrM8T1R0xfhpC-pZtFYOGNpfxcSFRGaUXDYQGauRGmFUfKlGZj4FVIw5CfDUBHkdWvQOTdjBgIEN0xSYMkhl1kHVxeKLPLK3K3rrE9fQpyo0cat8tm-cXK-gtN8qhW5cgbwDQdbICKlvMJrRI1Pv_FDThcqWKce3tXXntqvXIZ-JFDSolH3Vu8_PW_cPjsH9XftlPZMVFyTlvTWiSV1ehWkl9pdrXs57-rE3Q96o8jZIihq206qKVxISOlfSWMVU3sJeiSGX1DUtV04zXZmwxVjyV2LMeKFJhbxMxpom55lzaZXZbb74ma4a6VQy0C6EFcRnyqSL7qzRvoE-59lEFHdFMakumbK6-HTJJYyppZyDBFR3lj45WDZ5CKbK5vv15Zai9vmXTK9-Nm6LSA_Ck2pSa0NWFCHAzKnaaZshTfTMeFvO5gOiPoGRKms_LNPsAn1RJAK5RK2wGy1ZcVpvdDjrkktd0OsBsl3N2eaLOwqh44Ey2kRb345irI0oTfS7eYe4-Tlhbr2HWgfHuo0MKm17GKJQe1eo329w7DD3GEWvwKx9jzcioD0z_QxeE0B2f1bD6cT7YZvkOJ6xZfbAXID9Z_LptvTsLDrLDWq-ZGK9c3sS_V1ZX3RnLhqgenzLGDFr2Bc2CVN0IPtR_-lMGWKqL5JJlq2pyUn0nhfEfHmzb9a1_E9-1nJYhgWnt10fiVj8sKiZu1Xau4XSz-F5R6xf1NwaDR5GFTFlLiAXFh0eKVx-WF_NK_a0tGMDLvLMAzqB-3vlG4eyogUF9bMdxXmpX_mp5WWQ5W9c8_V5pQ2ziVI3w7Mz5l-qyVfqUSENMjBVMSoYmz0tFOxtNS1s628b0vj7elUxnUi7yz53Oy8tLe0HlTEzYT56wdiTma8U_6cz6pJzW6cOfi_4fV_3--XnJes2pV_7QunZW-Wljh2sSH7wky1SrtsUdOEKcLgLnEl97_SjOdnwLgTPNIMDws33XCzD8LEIQsMDuYrxiuS7KWsu2cdaSwMfwM-0AY4VleQ5GrEVcnHquZzoInOOQAJMsdtD1MThiEQ-D8wIXJdb1fROFAztQbnYtTDjsrt3tosLRxYglpksslBlWgIouZIuLiW7g-JgsIHaAkht4gYdRz7c9jFgz8IiJSmYSuKiKZnUdFM70fVRF82xUbbECP0DJdV2MHcQzCa5ComuQh-sINkquDfmMSReHQJHE2Nt1LEweEN-2UGkPCnqooub6uI7luSg7TOKiqgsBhhicTVxUXpkWKrxdz3JQrTJAFUk3IKgaaXq7sgUm1M20Ax9gGNVzq5pW1cO9kOWkpV6uP-hZ9htnL0bOaBbNYO5XA-rfQsz_UAp5bdN0bMf0y6uYL4zKIV1U079CVTc5SnF9kSOpvOIwBmb6Cmo9dyvk7-etT6ZvOW3LDMyuVf6g3dNzfTVMq-eQlfN5kbOQwagaf2d0IVL9Wgkt79RL4F6Qvtta39WEiVjfv5cwg4QvdGH0x6s8V6tO6d0dgdxFuk1m4sgOoy6EkHlDhXbZckSpC5bIE0luYBV5NiyUSuYulaxm7sU5wfwgMruZkm4zaW5zbzbJpyMR-MKSOZOnCtqRSW4TOUfS7zYRS3WxcTpjq_kpIk3k2c1ygTTLPPt4eDCOPZXtrvRqaDiq7jgN9GlQA61jYuKVUf4IdGL4dnu5UX45TYhQRxITiEZ2Oo3dajaIu9vsJFnN0tc6Pcvs5mW_QU6Txs63MAlhY0AN1H7H8IOMZPMouA2ysnkY3pEu2JKsaJGnBg9t4LlHdf1uNikxZmP3NiwX-Hg2McdC-Ik0D4Pd2FtOE2sw56V5kh9RqT8vkh29rdepdki9IuslVP8DL5FO-BQQvc72_zH2X0Njpd8=
Screenshots

Annotation 2021-10-21 091218

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Reproduce the issue using a new build and the Perfect Crime allocation, then search the codebase for the ascendancy notable and trace its damage calculation. Done means Perfect Crime grants damage only for builds using traps and not for an otherwise empty build.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop, game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.