PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Sort gems by DPS not giving expected results
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?
Adding a gem will be sorted in descending order based on dps.
What is the actual behaviour/value?
Awakened Added Chaos is appearing before other gems that provide more dps. Other gems such as Awakened Fork and Empower are also appearing out of order.
How to reproduce the issue
Attempting to add a 7th link to freezing pulse in order to simulate Uul-Netol's Vow. With sort gems by dps checked, awakened added chaos (~15%) is appearing above gems that are clearly better, eg inc crit strikes at ~36%
Build code
https://pastebin.com/YvdbiaM2
Screenshots
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Use the supplied Path of Building build code and reproduce the issue by adding a seventh link to Freezing Pulse with sorting by DPS enabled. Trace the gem-addition sorting behavior and verify that gems are ordered by their displayed DPS increase, with Awakened Added Chaos, Awakened Fork, and Empower in the expected positions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100