PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Sniper's Mark Don't Show Up on Effective DPS Mod Breakdown

Open
#3,426 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug good first issue
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

Not sure if this is how it's meant to be, but when hovering over the Fire Effective DPS Mod I think it should show Sniper's Mark in the Enemy Modifiers table, otherwise it isn't clear where the extra increased damage taken comes from. It does this for curses, but not for marks it seems.

What is the actual behaviour/value?

Sniper's Mark is not shown in the table.

How to reproduce the issue

Get any projectile skill active, and add sniper's mark to the build.

Build code
eNrtXN1z2kgSf17-ChVVd0-yrRlJI8nn7BX-DIlxHHCS3bykBjSAYiERaWRCtvZ_v56RsGUb7Ebx3u3D7W4lAvq7e3p-PQN78O_vs9i4EVkepcmrNtm12oZIRmkYJZNX7Q9Xpzt--9-_tg4uuZy-Gx8WUaw--bX1y4F-NmJxI2LgaxuSZxMhP64k2V9A0pwncirSpMe_ptlZGr5qX6SJaBtDnoSRXL0axTzPL_hMvGr3eTIRWdvg-Ugk4dHdB8eCh2IJxDMeJYN0dC3kWZYWc636JhKLXhoCWbd3-a5_VVMcJXXFYPcvB5cxX4psILk0cvjjVbsD7vOJOOYz-BOk8bgAUQ7xrV2L2IFlOe299ZyDuRDhLQfdtYlts_8-8WUmTsZjMZLRjTjKInk05cnozhNi7wbeJt4m9L0iltE8jlSmbi1kdBPL68caLGsT8VUqeXx8ObilDRgLdn2PBS5jNLD_Gr5U3vJttOxTJKeHMaSlgRbF250kkRQNmS_TKE-Tn_CvzrrRxaMijmF512mJ7e1aFoWMOdSz_I2c6WwYJQ9i41sMLAws17Nc5jzH2rmZbOtcJxP83bis_T4PoyKv2b2JqccTfpTmdxknG007j8biHunGyJ0McHR9aDE4SmXmpcigD0ocgzJ2K4aBrK3fjTHoi291Qm-juGPx_U4c9Z6Qd59yY9_oJndOuE_ZVycM_M323aQS9iZcJO8cfqpHj_YVbTcZ4YR-SDKRi-ym1to3i7_PUGUW00IVY19MBNLTcyFG0zPYVvtcClxd3lIx78ngKFpUcBThmuA4No7hYXCYs0u8gFiO43mM0KeE3A8U2X2SeMtQfeJZiGgdicgmy8E0EjGCWse1zoKKb50BWRp1li39PrnheX2hueRpb0pyXKEI2IGBIRQPIAVlL8hymaVfFZyKt-TrZLO0yJBJLIlRXl9Ol3k0gn1cQ9S-CIsRrpPdwsJeeiNmsEQ0rgSsXK94Z2PNH8aAtB94_5RTcbwVR0dKPro-TsOJ2ErJ9hyDYj6HZqHKDMt3GmUQ6Tyq7aQ7DEH9DqaJIz5HgK1UrUWsgjtqtILzaDKVCeA5vJYHLHhfpjzNt3Dmjhyt4hSwKQrEDq6j-5SSD2Oxb1jfrWE4HtPNIPYyXYAxUzXI5ohFWaPu8TtEs3HPOs1E8mOJln-PHKXgJAmLTFU3WsdDjsdqDvb0oK-eurN5mkn95hGPR7kW2U3mhTQSPaTPonz0ZViMx2oYb4OKTJ8inJyenhxddT-eVFbUWXKVrC9JMRuqYbL8W830JeVA6D5njNI45vNcwBw_5nEOsqOwSvQAuvtIouhhDq1mfAw1bN6jLIIgYojVAIkyWY_1GEo1Z6MIISs8FviAXS3nQlVAjo1Z1TAx1Ho8RlGW8yzOQT0349IgRnyJorxFNCjqk1h0oljtn7io9WAhlFsvjh42wiwaFhJZbXo-QdmhsDrKwToGRa4OHGEFiVBGVLARQ1vtNbiiBEiCTtuxGAsod-Sy1-3kil-LpGqWq8Z4oNdabuTQMc_ELD9cwo50qsL74KzkHgHsVVkBskMx5kWs3n9f8DiSS9XCa--el6euFN7Mp-lCoZtSjFrcOQT9_Lz8pBPLSoLSsbK99EwZqI9TOxoh6tfafH2mGiWjuAhhtK323Vu_Yz5UutvGRJ2_HqVFAvtIEsXq3FhttOHKiQeilVSl-JcDMKWiPYvTIY_pnew7v-oEZCVS7xbdckGq1chj6E9t41vpYld3AB2jivSSZ1J7MxEz9WlPSB5yyfe6EsKxp2Kyp42Dp7Uiddwf-HUr-S5YozIK8KR2NYXuayYaWqDm6kWJPhwfFLNZChVwCa1V8nxWFtvayOjIouNSVcInwedpcmvB6mR7XZyeisxtWT0tb12Qno5IKcBYRHJqlEPAar2V6fjbFmgtiw_MwafoOpJSZMMU9oZH8rSobdNUFXBZVPfEb5mgUoKxycK67Woc2S5lOgOPk1bWd-OUKaKXWjtJNBcZQODs-oVayt0xAiyg6wTmz-1Too36Jyy__F-5oW17EPXqSW86V5kQBi_jo9lp1evhRf1OTRlOVDRzyOayQioq_gkAd3hwfd-2Tdv1XMd0Atempk3cwDd95jLT9pkftA0Jumq3fcStLvKUbKvKyUkIyC28UEKrDvehf64ffplKOc_39_YWi8XunMtpOhbfIVC7o3S2Nwcx4MKODviOUrTXgX8O1X-9U19QZ2q9GU21wL2VxIPyVjAvxVevtEPaW0aJD_Uny6xVA9EaOkJcC0HHiG87GDrH9W0EHaVBgJHn-MwLMPJsQhBkgWNhomIzhvKWBh6hGDoS-Ch5zKMuxj7bczFRtglDZcN2HBSd65IAUy2BF3iYYrE8G-OuFzALFRVmY4rAYeAGhs5yLIxeYhMPZR-xUKXsBDgv7AC10qBWGCa3getjkkGcAKWXUMIwflDf8TB6XYdQD7WGSIDxl_iOzVCdj_o-Ks64NW4DHbIMUFVFPIqrZub7mF4FYWaY_DoOYQEqfoyh6o9Ak0TtHJ7jo_Q6qLgQC_Z7jL8B83E7lsd8VJyBEKXX8lHdhXoMty4ZwdAxaqPUsgDVdFlAcDjDttZ0AwB9d2gHXgC-2wj06GOg9weExjFtG1Ddn7egD9YhJaZLAwtAn-dQamqQAwAw8HwzcFhg-gG1TBcwg6nsYibsL3ZgEp_41KTUd6npwtbETAg9AMWA-KbLfHhyGQ1ckxDHD0zm2r5JQbcDf8KSMW1GqWu6luMqBfAhIE3bUzCTgVTHd3xF4ntaiqktdwPbs0ziEge8gHpwTQeemOsFYDTstWCYBwrBcsuCj4hyNvAZMYkH1KYuDdOFDgreuZbtmmC7pwLiOmBJQJWXxPOZSRxgchj1PLAEKh50uBZY5XoeMDnMsU0K5Qi2OV5AADHbPrjlU0oeA2RWA8j0LwLI3aPOm-Lix7fIvbw5e7v4kV5_GZz_fjo4vhE3_Gt_8flz_93XT8PO5DiWN8n5u5PPUZzPPqVnF5PB-Tc2pL8dzk7efx36H7_07YG7k3pv30SyM1zwr-PrH4timX-eF6Q_7n_ZCaY02wEhae-NS67eDiafiOx9HOeXX8Tnt8HkPTl9TSbi7bszJ_gbAXX6f6C-DcB9aaCOBS1YoL6hPTYG6thBAolJkXsGdgt6aaD-YIskPwnUsTvz3x2pY5EIFqmjp-L_EVLHIj4sUkcjTSRSx04SWCSMRepY5I9F6ljkj51MsBPRSyN17CSLPc7AnlMgjz2Qhy0vDNQ3HHqsB-oHe-qkVj1cpFLoz9Sbqxf6HPdjJBZGLng2mg5k9qot9BVt2_iRprPfX7V3PMfedQAGU4-Wd32vBZc9Pr-9q1CE1UUhWV0USi6PI5gCMn3HuTp4VpS_gUg_8HcDQN2O5QG8KreDA32uXR0qq-eBKM-oi1wMxChNwvJySL9du15UpPqOtLpU6fMskst948NF9_2Hk9bVVBjdBIaSLJ1wdcPaGsx4HBtHcaFGFeONWIi4dS74pBD7xrGIoywqZq3ubB5Ho0jm-4bV6oRhboANGYTXSMfGoFCeRclEh1oZcN8SutaSc1AulmJ1xH4KVrQ-grYw4kllRvnV8n2jJ8JHRuhvFxo8CY3yqYyGoS5ijVkaRuMIRgAjSoxSiMEzYVxlPMnHaTYToSFT4zBdGL0V6Qbb7fu29zv9k9YFFIgiaPV4xqHGpkpS6yjjY5gp9g2V29ZlJsbR931D_fzliRcqdIgX1V3yvkGtVlXX-8bZzu2_LV1vffFt3_BIPU6k9Yfkk3w_V99_-ZNY_1A3QZngOURg9dVEQ3855r7_gzhdfVOoCmxtya6-B1VV5RMVWS_EdTIHCz43OsNlnvPYqBb2uql7DetDNopje-TFParDNIWSbmbQOl-eMepQxHJLllOYZK8NG2USXWeS3Sy8uCDQF2JzmhnJmmljzaNJnknwunp6JgOvRTwTcltFayqJNdHzTPmdxdA08iaC7eariDTR5zSrBdKs8pzn04MJ7LZi15VXQ8dRfcdtYE-DHmg_pyZcGuX327ZM3_ooN6ovtwkTakliEtHIT7dxWGmDvLNmK8luVr729lXmNG_7DWqaNA6-jSkIB0PUwOyfAD_ITDbPAmtQlc3T8BPlgm3Jihe5avCkDSLXh1kOhwS2bhQbw9uwXeDz2cQdGxEn0jwNTuNouU28wayX5kX-jEmdWRGv2dvKmRNGRn06o8889O9c0mQcTR79akUNmZE6tdA_I4Dot41hmsaCJ9WRyt5mlpNEzJaDUZqNpuqXrlvy8fkcwyUUcf0XbKtf1uxQdxN5Nz9M1TcUVz_bGURZkT9r0WEWSRmLdSYd7K3Cd7D38P8f8h-Ex3AG
Screenshots

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with any projectile skill and Sniper's Mark, then inspect the Effective DPS Mod breakdown and compare its Enemy Modifiers display with curses. Done means Sniper's Mark appears in the table when it contributes increased damage taken.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.