PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Affliction Charges (Olesya's Delight) "%#more effect of non-damaging ailments" not factoring in on calcs screen

Open
#3,179 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
What is the expected behaviour/value?

Having %#more effect of non-damaging ailments from infliction charges increase Current Shock in calcs screen (increase is correctly shown in "shock effect mod"

What is the actual behaviour/value?

%#more effect of non-damaging ailments from infliction charges have no effect on Current Shock

How to reproduce the issue
  1. Select Witch with Elementalist Ascendancy and spec into Shaper of Storms
  2. Equip any spell skill that hits (arc works)
  3. Equip Olesya's Delight
  4. Go to "Calcs" tab and note "Current Shock" number
  5. Go to Configuration tab and check "Do you use Frenzy Charges?"
  6. Go to "Calcs" tab and look at "Current Shock"
Build code
https://pastebin.com/Auj9CYBk
Screenshots

image
image
image
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Load the supplied Pastebin build, reproduce the steps through the Configuration and Calcs tabs, and compare Current Shock before and after enabling Frenzy Charges. Trace the calculation path responsible for Current Shock and confirm that the non-damaging-ailment effect from infliction charges is included; done means the displayed value increases as reported.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.