PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Second "#of beams" window for Storm Rain when used in dual setup (self-cast and with ballista totems)

Open
#3,085 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

When two separate Storm Rain setups are present in a build, only one "# of overlapping beams" window is available. This generates incorrect DPS values, as the two skills have different damage calculations based on different supports, but they both use the same window.

Describe the solution you'd like

Enable a second window for the number of beams when a skill setup with a ballista totem + storm rain is present alongside self-cast storm rain.

Describe alternatives you've considered

An alternative workaround could be for the single window to count overlapping beams of all Storm Rain instances at once, but I don't see how it would correctly calculate DPS for those said instances.

Additional context

Current PoB for reference: https://pastebin.com/bpCdMzBY

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by locating the existing Storm Rain "# of overlapping beams" window and the handling for self-cast and ballista-totem setups; done means the two setups can use separate beam counts and produce correct DPS values.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.