PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Search function in Notes

Open
#3,025 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

As some streamers now use the Notes tab to describe builds in great detail (e.g. Zizaran here), I think it would be great to be able to search through Notes.

Describe the solution you'd like

I would like to have a search box in the Notes tab that searches the text within and can be auto-focused via pressing Ctrl + F as this is a well-known key binding for searching through text.

Describe alternatives you've considered

I guess the same functionality may be achieved by selecting the entire Notes tab's content, copying it into your favorite editor and using the search function there.

Additional context

Please find below a quick mock-up of what my proposed solution could look like (note the search field in the top right corner).

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Notes tab implementation and its text-rendering or input entry points. Check how keyboard shortcuts are handled, then verify that Ctrl+F focuses a search box and finds text within the Notes content; the issue's mock-up shows the intended placement.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.