PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Full DPS unable to account for main minion skill and Summon Phantasm support at the same time in one gem link
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Example pastebin: https://pastebin.com/V3UUp1Nq
Having any minion skill linked to summon phantasm support will prevent Full DPS from accounting for both setups at the same time, not an issue for non-minion/count skills such as puncture + sps
In a similar way that Elemental Hit dps can only display the dps for fire, cold OR lightning, for a Raise zombie linked to Summon Phantasm, the skill setup is only able to select either the phantasms OR the zombies as Include in full dps
A workaround is to duplicate the gem links and have one setup as zombie and the other as phantasm
Related already raised issues:
- SPS will inherit skill count, level and quality from main minion skill gem instead of itself
- Skill count for abilities such as cobra lash will count the number of cobra lash projectiles as the number of phantasms
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Pastebin example and compare the two related issues about Summon Phantasm skill counts, levels, and quality. Trace how Full DPS handles a minion skill linked to Summon Phantasm; done means both the main minion and phantasm setups can contribute to Full DPS without duplicating the gem links.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100