PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Improve the process of adding support gems to skills not coming from gems

Open
#2,845 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

This always frustrates me so much. You can't add them directly to the group as it's locked and can't be edited. PoB says, however, that socketing support gems into the item it's coming from, if any, will automatically add them to that group. But creating a new group for the item slot DOESN'T in any way take into account that link, even if you chose the skill as your main, and so you are left completely in the dark and have to try every gem out yourself. It's not so bad if at least the skill has an equivalent in available active skills, like the level 30 Reckoning from the Surrender, you can simply add that skill to the group and forget the item's skill exist. It doesn't work great however for every other skill, and so I'd like to have this oversight to be fixed. Thanks in advance, you rock!

P. S.: Why do the skill groups even have to be special? Why not make groups for such skills editable, but only prohibit changing the main skill of the group? This also lets potentially to see what a skill does and other things about it w/o having to look them up online.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by locating the code that creates and locks skill groups for item-provided skills, then determine how support gems and item links are represented. Done means item-provided skills account for linked support gems and the intended group information or editing behavior is available without external lookup.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.