PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Set limit of active banner skills
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Under normal circumstances, you can only be affected by one banner skill at a time. Currently, there are no checks in place to ensure this behaviour. Any fix would also have to correctly set the limit of banner skills you can be affected by to two when having equiped the Perfidy unique chest armour.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not name files or tests. Start by locating the Lua code that applies banner skills and the handling for the Perfidy unique chest armour; trace how active banner skills are counted. Done means normal builds allow one affected banner skill, while Perfidy allows two, with checks covering both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100