PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Dominating Blow full DPS calculated incorrectly
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
When calculating Full DPS for Dominating Blow, count >1 multiplies both the DPS from the sentinel and the DPS from the player, even though it should only multiple DPS from the sentinel.
E.g. if one sentinel deals 100 DPS and the player deals 50 DPS, setting count to 10 will result in (100*10)+(50*10) = 1500 DPS, rather than the correct (100*10)+50 = 1050 DPS.
- What steps will reproduce the bug?
Add Dominating Blow to Full DPS calculations, and put in any number greater than 1 for the count - Does it reproduce every time?
Yes - Provide a build code:
https://pastebin.com/HhCF1kpf - Screenshots:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the Dominating Blow Full DPS calculation path and reproduce the issue with the supplied build code, using a sentinel count greater than one. Trace how the count is applied to sentinel and player DPS; done means only sentinel DPS scales with count and the corrected result is covered by an appropriate test or verified calculation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100