PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Mirage Archer and Barrage interact to Create Incorrect Tooltips

Open
#2,680 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

  • What happened?
    DPS Delta tooltips for activating support gems or added damage auras were incorrect while both Mirage archer and Barrage Support were linked to the main skill, but were correct when either of those supports were deactivated.
  • What were you trying to do?
    Decide which auras and support gems to use.
  • What steps will reproduce the bug?
    Open this pastebin: https://pastebin.com/YUxmxiXj
    -Hover over the "Enabled" checkbox for Added Lightning Damage or Herald of Thunder
    -Observe that in the hover tooltip "Mirage DPS" % gain is much higher than the Total DPS % gain, when they should be identical +/- rounding
    -Actually check one of those boxes, observe that the combined DPS increased by less than the tooltip said it would (reflecting the correct gain in Mirage Archer damage)
    -De-activate either Mirage Archer or Barrage Support and repeat above, note that there is no such issue.
  • Does it reproduce every time?
    Yes
  • Provide a build code:
    https://pastebin.com/YUxmxiXj

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by loading the linked Pastebin build and reproducing the tooltip mismatch with Mirage Archer and Barrage Support both active. Compare the hover preview for Added Lightning Damage or Herald of Thunder with the actual DPS change, then repeat with either support deactivated. Done means Mirage DPS and Total DPS show the same gain, apart from rounding.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop, game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.