PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Issues with Impale calculations
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Thank you for reporting an issue.
Before reporting a bug, please make sure that you are running the latest version.
You can get the latest version number from CHANGELOG.md
Please try to fill in as much of the template below as you're able.
- What happened?
- Created Champion EQ Warcry in PoB with Impale Overwhelms x% Physical Damage Reduction Nodes. "Impale" calculations have two errors:
-
- In the "Impale" calculation display, Impale Overwhelms x% Physical Damage from nodes AND the skill gem are not counted toward the "impale enemy physical damage reduction" multiplier in "MH Dmg Mod" tooltip
-
- In the "Impale" calculation display, "MH Dmg Mod" tooltip automatically adds 1.00 to the multiplier, which does not match the "Impale Damage" that is subsequently output.
-
- What were you trying to do?
- Calculate Impale damage via "Calcs" tab.
-
- What steps will reproduce the bug?
- Creating Champion EQ Warcry in PoB with Impale Overwhelms x% Physical Damage Reduction Nodes
-
- Does it reproduce every time?
- Yes
-
- Provide a build code:
- https://pastebin.com/sr192BsC
-
- Screenshots:
- Screenshots:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the Calcs tab using the linked Pastebin build and reproduce the Impale display for the Champion EQ Warcry setup. Compare the MH Dmg Mod tooltip with the resulting Impale Damage, including overwhelm from both passive nodes and the skill gem; done means the sources are reflected and the multiplier matches the reported output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100