PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Incorrect mod damage values being generated with mirage archer
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Starting with this PoB https://pastebin.com/8ae3Sk1T Removing Mirage Archer appears to fix the issue.
Build is showing negative/incorrect values for mods that have no effect on the build. Example for adding +1 lighting spell gems to the equipped bramblejack
Attempting to create a white jewel will show negative values
Allocating the jewel socket to the left of Perfect Agony and actually equipping this item will have no effect on the overview
This bug breaks tools that use the preview value, such as pob-item-tester.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked PoB build and reproduce the incorrect preview values with Mirage Archer, including the Bramblejack mod and white jewel examples. Compare the generated mod damage values with Mirage Archer removed; done means irrelevant mods no longer produce negative or incorrect previews and pob-item-tester receives correct values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100