PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Full DPS for multi-part skills
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Is your feature request related to a problem? Please describe.
The full DPS calculations currently does not include all components for some skills. For example, earthquake has both an initial impact and an aftershock, and both should be included in the calculations. Another example is divine ire's channeling and release.
Describe the solution you'd like
I would like the default to be that all components are included in the full dps calculation automatically, just like the duplication workaround described below.
Describe alternatives you've considered
My current workaround is to manually duplicate the skill group, and set the main skill on the sidebar so that both parts show up in the full DPS calculations.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the full DPS calculation and the handling of multi-part skills such as Earthquake and Divine Ire. Trace how duplicated skill groups currently make both components appear, then verify that all components are included automatically without the workaround.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100