PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

[2.1.1] Total DPS is not shown correctly in the Build summary panel when equipping gems

Open
#2,558 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

  • What happened?
    Build summary does not show correct DPS numbers

  • What were you trying to do?
    I was creating a build for 3.14. Initially it did not have any items and then I created a wand which has some spell damage stat.
    It says that I should be getting +150k total DPS. But when I equip the gem, the summary only adds 40k.

  • What steps will reproduce the bug?

  1. Create build using Incinerate + CWC + Bodyswap.
  2. Create a wand with spell damage
  3. Check how much increase you should have
  4. Equip that wand
  5. Observe the Build summary DPS numbers
  • Does it reproduce every time?
    Yes

  • Provide a build code:
    eNq9W21v4kgS_rz5FRbSSXdah7hf3LajZE9ASIaZJMNA5vVL1JgGvDE2sQ0Jc9r_ftVtE0wCpOMd7YzEgF2vT1VXV7U9J_99nIbGQiRpEEenNVS3aoaI_HgYROPT2ueb80O39t8_Dk66PJt8HDXnQSjv_HHw24n6boRiIULgs4Av48lYZF9WssgtXJvxKJuIOLrif8bJRTw8rV3HkagZAx4Ng2z1yw95ml7zqTitfQ0yf1IzeOqLaNhaX2-HYiqijIdBmtWMKQ-ifuzfiewiieczMKBmLALxcBUPgbZz1f3YuykpD6KycrD-t5NuyJci6Wc8M1L4OK01AAQ-Fu8CEL_g4RzkIGwxUrdY7Wgvyxmfwqc2V38mxPCJ2qsz-5-k7CaiPRoJPwsWopUEWWvCI39t_E6r30p7NQ-zYBYGIlkDs4v-3QvRMp92EN_EkARn3f6aFjFquXUbe7-cJV7nwk57IGEnzRDgf5uCzjgKMlHmwcTBdWy_wrCZax51vX2GvdSCkOu4Vt1x9vJ14yCNo2qQvcGnVjwdBNFz6F4zcMXVWIzfYF4jEfzjKM_9Hh8G83SdyHgX0xWPeCtO12mwU3w_KyU6prvIeuK-TLkzq87EYynIe6SVCZm7M3mitQuE4D3yypSY2rvtW8QZlPnXPbkMRut8xS6z9tQw_1hSdyK_FFd7n-DPUSJSkSxKxW-fik2Wrkhgk8l0io5k7ImxiEpq6mwf9aUQ_uQCtqkez8TrKMlEWxvi7A65QklSb6C0e7eRpFtQ2qdik-UNKEnGTZQct-7to34jSu1IJONlfxKIsBTwvduif1xmKoPGtNRs-qPFst0pzOo77WwveFpeTBTvXyUFfdmb3UERsDkBw1A822N_IUc3if-ULUX4NrZGMo3nGsVQ-ZwTl13eDVJ3skwDH3YjtVv2xHDu6xWrp9boKl6oflM1VtBVrlnrnrOLuxlCS_rMebwvOcNwK8tuwLKM-3dn8XCsjbHS8iaO8yAByNKgtOsdIvY69Ufohlt89rqCViyX1aYCgl6n1lZwGYwnWQRzir6WZyz6vkx4nD5XQ3XItVWcz8PN5hU2cNupU8uxHUTJzsDfBZt8GR-E4tiwHtFwxKmPdq-e-AFMm8hpLtVY-yXqK75uRnYadp6I6OdSW_4GuZaCdjScJzLXtXU853ip5uRIzbvyW2c6i5NMXWzx0E-VyE40m2dGpEbVaZD6t4P5aCSn0RqoSNQw3T4_b7duOl_ahRVlllQG6zaaTwdyXsr_XQ9MfaHKl-HHYchnqYBBdsTDFGQHwyLQfajZfqZFD9NWMUXoUH_liZ8EAKIOsRyYtExW46oOpRwltQghKjwU-oDdLGdCZkCqi1lRPnWo1TioRZnPWXoOqlFOLwzC50styqdWRYu6HYpGEMptUQ-1K1gI-Y6qRw_bWxIM5plmtqnJQssO2VxrOVjuL7UszjsYLdlFj6dDW2woerkGDYR2NM7ESEAWa65mVSVu-J2Iihq4qncnagmlRgqF8EJM0-YSNppzidqzmX6DALagZA6yh2LE56G8_mnOwyBbntaiICxfv8xPFdXVdBI_9OezWS5JLtsUcL-8zO80wqwQItWszM-dkzaqk8KGaunUb-WBOi4MIj-cD2HYLPbXlXUhH0jdNWMsTxZb8TzKCktEJHfQ4YowDWN5WiL4DBBEteeapBJpx28nYFnBexHGAx7iJ5RV2YcqBM1ZrsetrU5UsVXbYEJPaiVPRybU40weokZj2YK11DnqfQ5FR9UABWZB3-VJprwei6m8eyUyPuQZP-pkANuRxO5IWQ3foMWG-CVqdrlfBch66f5K7hpSP3cCvsldTXbt8uRhLU2xXAWROh7uz6dTMHrYhbqa8XSap-Q-tLSRKdKlxdPs6wSGElm6I2iDAavtGO1D5Sn19orbhtA2OKQQ40FKMcpifp3vrTiBhQy79uwXpcMWgbrONuPhMn2QPe4_HPlG4vNI9OfJWPyNgG-Tout6zmvkzHmxzRFVdTQvn_LrTSKEwfOqoRhRUbzgR_khiLQWgwLoKGGtUeRSkzquQ0yMPWwiGzHHRBZCtkldwrCJHWwRkyLqYBPGBM8xKXaYBdeZ7ZnMIp4L9DZCJnIxNqmHbQo3CSami-AeAVHERNTCCPgtCupsC5uuR13Tpsx2TI8SbDJEsGU6BESCKmQS4ti2iW3XpAQswgw7oNOzmJTiUGYiRIGBISalE8SoadueB9-luTbY6JnIsz2QgS3XlQZQCwx1JYnHiA1XPMJM4oAgaYhHwQGXyeuWrSAAwRhMy68zoLFBq4scqQlTxyTgn2WCo9Q2bRccBLc97IHp2GMmzaEl0mLiepYFVwhw2YzKK4SCCQQ7SBpFJIlr2dIaBmBTx_NMGxFAgGEKSmzLxUxaAwFhjvTVxcgFPBAQImJZ8Ak_pPcYsLEdSkyPuMxkFIMG1wULHQx81CLgCmbSIYidBMZ1INbwyUAlBdUmI1I9QxjiSygDawFIQIRZEFNm2RaCm64FuDgOOMEcGRkgkaGywE_Aw5LGupAxDlgBFxDw2zYAA-5bEiKHOZDlGeRs6SkfosUDPJmjpNjz2kNoVofXMl2L1f25d6m-_DbJsll6fHT08PBQn_FsEo_EI9TDuh9Pj2YgBpbCoVrQh1LRUQP-NBtXrUaz-X3-0O54Z-nte_rRZdPZWTw-Gw243xk0FokT3HWbj07jx_Te6TR-2OnN4Jxkn3phcGmh7-07_PGw05h3H97R7qDxqdM7w1z4379N7oKl715__jm4vrebl93PTWt5-eVujHHr_vrm8op9fX_GEP_xHuTN3rNw1GxPl-dfmhe32agb9u3Dr-JTMOhNW-0Py-_3Z1-_eR8sh3Rwa0puL5oN8S380U6SxW1nevuJP8az0YfJLKV4tjz7edm7itoLNPmxeP8hYdb4GhGnNUymfy7ZYe_9hRX2Dm9Giz4dhk32Lf0yOk97n33uh98uZrfBxXLajt89fDgfDMd3OMM37x9OTxXQRyukT_InpGkOe_FLlRAZKcQgF6ENyvJSWMzGW-igElgadJBchOrQUdslGnRQ2DwdedRljqcjD0qaBplHLR1UYD1qeYs9B2EdOii6WvKYg20d-6AQ66AMJVgrGlDzmA6dbUN11YHZ8Ryd5MOww-gkFaw5HVgYJjrWwQaHdHJK7k5a8ihinlY0LC21su5ruUE8raUGyaIjD_ZlVwdl2KO19EJsLR152KWOVnQRdl2tRQS9hJY8xrRw9ixXJw1sirCjtXg9VycPoFUhOvYhB-ulM3NdnWIFjSPBWvhRLb0YO1QnbtCueq7W-sBaxQqaNMfSWh96xZl6TI8Olq_W1osRQ3p-6JBBv63lLiGM6MhzPKYljnla4piHtMRRum3HgqFq3e3AD5if1KglByz55TrOhLonL65-qPHrSyAejFTwxJ_0s0Se_PyM4-n305pLvboLEwI08bYtewx54PRO8OyKz55GU0lbHFe5xWFVxrOzYDQSiTpqW02JkvCbfAZFWR3KGSw1aOrzR4knavwsxkD5vS_yeXKeir7w42iYnzKpy6UTLkmqTuqKk6YeT2BEPTZ6jV77QD34M77yaHjQTeLZRPjL_Fcr4SPozY8NaRfcE6Pg8djInxOqE7-PUa7O3nazEQ3lceqKhj7R_C_h0VgcW3X7r3w6l8dSilGO1QoidHvQn4_K1OgvSZVLLl40IE808mW9zR_FUd-xga2DItzHRvMQ_h4oBT1xf2ww96AznYWBH8i76KBk2L8JO6TWf_4lD_8SwVMxzF0zcgsOHG_nLeSUb0mrV3d-J8jIYmPKH4PpfGpIdA5-V5eUTUY8MjjIUSy5yPxkUsKiMvcqHvakiYYyVD5itmtFWIuTAxnozYjjLRHPT6-N_Pi6-OfgJsh4FIBd_VkAtKvL25NAL4bPqNFfW3JnnRcbUSwp6KzAlEdi6oEQ_rWRtw7o7nBu3FGHcsqEtwSuFJZ-GK-e5K3Pg1cV6ukp3gui0h66eiWrWP17Vn55wW9T3H_gM6MxWKYpB4Pz2rmledrG-pwN67G9cHWDqhnHWVrRoG2-vGJUU4TZG1nOQ57eGUTLJLzNJFINXj0Q8C9io9WMZNW0sepoolcCvC2fXonAOxFORfZWRVsyiVXR80r6QaVdyJcU3i6YVF9FqIo-Wi0XULXMo6-HRwfYt4rdll4VHdeqO3YFeyrUQPKamuHSyJ9mvzF821GulF92FSatJakTiEp-2pVhxRXizqqtJFItfcnbs4xWL_sVchpVBp_oJATVIapg9t9ofjQj-aKv1I4Cq5CV1cPwN9JFtyT31fNnrVWjT1oBuV4QjfU6gTcXip3wViwX-vGs4g7RwAlVDwOtjJZdxRud9VI9yV8xqTGdh1v2tnwwhZFRHYCpsyX1smocjYLxi1dP5ZAZyLfA1LuA6p2WQRyHgkfFyVXx6lfBfXL0_L-C_h82e5VC

  • Screenshots:
    Before equipping
    image

After equipping
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the Build summary panel with the supplied build code, Incinerate + CWC + Bodyswap, and a wand with spell damage. Compare the expected DPS increase with the value after equipping the wand, then trace the gem-equipping and DPS-summary entry points. Done means the summary shows the correct total DPS consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.