PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Warn users that custom spectre details may be overwritten when updating
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Currently, if you add custom spectres by manually editing the .lua files, this prompts an update with no changes listed in the change list window. If you accept the update, any changes you have made are overwritten without warning.
Describe the solution you'd like
Either add a warning in the changes window that your changes to spectres will be overwritten, or add an option to skip the spectre-related files when checking for updates.
Describe alternatives you've considered
For now, the workaround is not to press the update button after entering custom spectre details.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the update check and change-list window, then inspect how spectre-related .lua files are handled. Compare the warning and file-skipping options described in the issue, and consider the work done when custom spectre edits cannot be overwritten without clear user notice.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- desktop, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100