PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Ruthless Support precise calculation mode.
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Is your feature request related to a problem? Please describe.
Ruthless support's Ruthless blow is forcibly averaged into calculations. Making slow hitting build's dmg estimation for one shot purposes troublesome.
Describe the solution you'd like
It would be really nice to have a menu where you can swap between "no ruthless", "average damage" and "Ruthless blow proc damage" when using Ruthless Support similar to the menu/options that warcries have in the calculations tab.
Describe alternatives you've considered
Any other user option to enforce the ruthless blow proc dmg into calculations instead of currently forced average.
Additional context
Screenshot of how Ruthless Support is currently implemented in calculations https://imgur.com/a/gUHDqHe
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names the calculations tab and Ruthless Support but no source file or test. Start by tracing Ruthless Support's calculation path from that tab, then inspect the existing warcry option handling; done means the UI offers no ruthless, average damage, and proc damage modes and calculations reflect the selected mode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100