PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Carrion golem flat damage stacks from multiple gems

Open
#1,542 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Having more than one gem enabled in the socket group adds the flat damage to minions each time as long as it is a new socket group. It is also sorted at the top even if it is enabled already.

https://i.imgur.com/fSCAdqJ.png

https://i.imgur.com/R9lxZzB.png

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is named. Start by reproducing the Carrion Golem setup with multiple enabled gems in separate socket groups and compare the displayed minion damage and ordering with the screenshots. Done means flat damage is applied only as intended and an already-enabled entry is not incorrectly sorted to the top.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.