PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Molten Shell and Vaal Molten Shell
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Molten shell and Vaal molten shell have had their supportability broken, they can no longer be supported by various supports which work ingame and in previous versions of PoB
This is likely due to "spell" beign removed here https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/1201/files#diff-4b9f53b244c69131ddf642633e1f90c4L3353 however adding it back in causes spell damage to scale molten shell which is also incorrect
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the referenced change in pull request #1201, especially the diff around line 3353, and reproduce the support interactions for Molten Shell and Vaal Molten Shell. Done means the supported skills work as they did previously without allowing spell damage to scale Molten Shell.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100