PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Search talismans by effect

Open
#10,316 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

When creating a talisman, you have to either scroll through every option or have the base type names memorized to find the enchant you want

Describe the solution you'd like

It would be nice to be able to search by effect, similar to how you can search anoints by stats

Describe alternatives you've considered

No response

Additional context

I've been looking around the code but it seems more complicated than I thought. Anyone else willing to take a crack at this?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the talisman selection UI and comparing it with the existing anoint search by stats. Identify how talisman effects are represented and how the selection list is filtered. Done means users can search talismans by effect instead of scrolling through every option or memorizing base type names.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.